Change to improve error on invalid style

Author: wooorm

lib/handlers/element.js

@@ -196,11 +196,12 @@ function parseStyle(value, tagName) {
   try {
     styleToObject(value, iterator)
   } catch (error) {
-    // To do: use `cause`.
-    const exception = /** @type {Error} */ (error)
-    exception.message =
-      tagName + '[style]' + exception.message.slice('undefined'.length)
-    throw error
+    const cause = /** @type {Error} */ (error)
+    const exception = new Error(
+      'Could not parse `style` attribute on `' + tagName + '`',
+      {cause}
+    )
+    throw exception
   }
 
   return result

lib/state.js

@@ -99,6 +99,7 @@
  *   Casing to use for property names in `style` objects.
  */
 
+import {ok as assert} from 'devlop'
 import {html, svg} from 'property-information'
 import {position} from 'unist-util-position'
 import {zwitch} from 'zwitch'
@@ -185,8 +186,8 @@ function invalid(value) {
  *   Nothing (crashes).
  */
 function unknown(node) {
-  // To do: use `devlop`.
-  // @ts-expect-error: JS guarantees there’s a `type`.
+  assert(node && typeof node === 'object')
+  assert('type' in node)
   throw new Error('Cannot handle unknown node `' + node.type + '`')
 }
 
@@ -331,9 +332,8 @@ function createJsxNameFromString(name) {
   if (name.includes('.')) {
     const names = name.split('.')
     let part = names.shift()
-    // To do: use `devlop`.
-    /** @type {JsxMemberExpression} */
-    // @ts-expect-error: hush, the first is always defined.
+    assert(part, 'Expected `part` to be defined')
+    /** @type {JsxIdentifier | JsxMemberExpression} */
     let node = {type: 'JSXIdentifier', name: part}
 
     while ((part = names.shift())) {

package.json

@@ -44,6 +44,7 @@
     "@types/estree-jsx": "^1.0.0",
     "@types/hast": "^3.0.0",
     "comma-separated-tokens": "^2.0.0",
+    "devlop": "^1.0.0",
     "estree-util-attach-comments": "^3.0.0",
     "estree-util-is-identifier-name": "^3.0.0",
     "hast-util-whitespace": "^3.0.0",

test.js

@@ -362,7 +362,7 @@ test('toEstree', async function (t) {
   await t.test('should crash on an incorrect style string', async function () {
     assert.throws(function () {
       toEstree(h('a', {style: 'x'}))
-    }, /a\[style]:1:2: property missing ':'/)
+    }, /Could not parse `style` attribute on `a`/)
   })
 
   await t.test(

tsconfig.json

@@ -5,7 +5,7 @@
     "declaration": true,
     "emitDeclarationOnly": true,
     "exactOptionalPropertyTypes": true,
-    "lib": ["es2020"],
+    "lib": ["es2022"],
     "module": "node16",
     "strict": true,
     "target": "es2020"