Merge branch '3.4' into 4.2

* 3.4: (24 commits)
  Apply php-cs-fixer rule for array_key_exists()
  [Security] Change FormAuthenticator if condition
  handles multi-byte characters in autocomplete
  speed up tests running them without debug flag
  [Translations] added missing Croatian validators
  Fix getItems() performance issue with RedisCluster (php-redis)
  [VarDumper] Keep a ref to objects to ensure their handle cannot be reused while cloning
  IntegerType: reject submitted non-integer numbers
  be keen to newcomers
  [HttpKernel] Fix possible infinite loop of exceptions
  fixed CS
  [Validator] Added missing translations for Afrikaans
  do not validate non-submitted form fields in PATCH requests
  Update usage example in ArrayInput doc block.
  [Console] Prevent ArgvInput::getFirstArgument() from returning an option value
  [Validator] Fixed duplicate UUID
  fixed CS
  [EventDispatcher] Fix unknown priority
  Avoid mutating the Finder when building the iterator
  [Validator] Add the missing translations for the Greek (el) locale
  ...

Author: nicolas-grekas

DependencyInjection/ValidateWorkflowsPass.php

@@ -34,13 +34,13 @@ public function process(ContainerBuilder $container)
         $taggedServices = $container->findTaggedServiceIds($this->definitionTag, true);
         foreach ($taggedServices as $id => $tags) {
             foreach ($tags as $tag) {
-                if (!array_key_exists('name', $tag)) {
+                if (!\array_key_exists('name', $tag)) {
                     throw new RuntimeException(sprintf('The "name" for the tag "%s" of service "%s" must be set.', $this->definitionTag, $id));
                 }
-                if (!array_key_exists('type', $tag)) {
+                if (!\array_key_exists('type', $tag)) {
                     throw new RuntimeException(sprintf('The "type" for the tag "%s" of service "%s" must be set.', $this->definitionTag, $id));
                 }
-                if (!array_key_exists('marking_store', $tag)) {
+                if (!\array_key_exists('marking_store', $tag)) {
                     throw new RuntimeException(sprintf('The "marking_store" for the tag "%s" of service "%s" must be set.', $this->definitionTag, $id));
                 }
 

Tests/Validator/StateMachineValidatorTest.php

@@ -94,7 +94,7 @@ public function testValid()
 
         (new StateMachineValidator())->validate($definition, 'foo');
 
-        // the test simply ensures that the validation does not fail (i.e. it does not throw any exceptions)
+        // the test ensures that the validation does not fail (i.e. it does not throw any exceptions)
         $this->addToAssertionCount(1);
 
         // The graph looks like:

Tests/Validator/WorkflowValidatorTest.php

@@ -29,7 +29,7 @@ public function testSinglePlaceWorkflowValidatorAndSimpleWorkflow()
 
         (new WorkflowValidator(true))->validate($definition, 'foo');
 
-        // the test simply ensures that the validation does not fail (i.e. it does not throw any exceptions)
+        // the test ensures that the validation does not fail (i.e. it does not throw any exceptions)
         $this->addToAssertionCount(1);
     }
 
@@ -64,7 +64,7 @@ public function testSameTransitionNameButNotSamePlace()
 
         (new WorkflowValidator())->validate($definition, 'foo');
 
-        // the test simply ensures that the validation does not fail (i.e. it does not throw any exceptions)
+        // the test ensures that the validation does not fail (i.e. it does not throw any exceptions)
         $this->addToAssertionCount(1);
     }
 }