updating shared-entry-contact-plugin code for emit

Author: weaverryan

lib/plugins/shared-entry-concat.js

@@ -24,8 +24,7 @@ module.exports = function(plugins, webpackConfig) {
 
     plugins.push({
         plugin: new SharedEntryConcatPlugin(
-            webpackConfig.sharedCommonsEntryName,
-            webpackConfig.outputPath
+            webpackConfig.sharedCommonsEntryName
         ),
         priority: PluginPriorities.SharedEntryContactPlugin
     });

lib/webpack/shared-entry-concat-plugin.js

@@ -10,16 +10,15 @@
 'use strict';
 
 const fs = require('fs');
-const path = require('path');
 const sharedEntryTmpName = require('../utils/sharedEntryTmpName');
+const RawSource = require('webpack-sources/lib/RawSource');
 
-function SharedEntryConcatPlugin(sharedEntryName, buildDir) {
+function SharedEntryConcatPlugin(sharedEntryName) {
     this.sharedEntryName = sharedEntryName;
-    this.buildDir = buildDir;
 }
 
-function getChunkFilename(stats, chunkName) {
-    const chunk = stats.compilation.namedChunks.get(chunkName);
+function getChunkFilename(compilation, chunkName) {
+    const chunk = compilation.namedChunks.get(chunkName);
 
     if (!chunk) {
         throw new Error(`Cannot find chunk ${chunkName}`);
@@ -36,8 +35,21 @@ function getChunkFilename(stats, chunkName) {
     return jsFiles[0];
 }
 
+/**
+ * @param {Source} asset
+ * @return {string}
+ */
+function getAssetSource(asset) {
+    let content = asset.source();
+    if (Buffer.isBuffer(content)) {
+        content = Buffer.toString('utf-8');
+    }
+
+    return content;
+}
+
 SharedEntryConcatPlugin.prototype.apply = function(compiler) {
-    const emit = (stats) => {
+    const emit = (compilation) => {
         /*
          * This is a hack. See ConfigGenerator.buildEntryConfig()
          * for other details.
@@ -55,23 +67,26 @@ SharedEntryConcatPlugin.prototype.apply = function(compiler) {
          * executed. This fixes that.
          */
 
-        const sharedEntryOutputFile = path.join(this.buildDir, getChunkFilename(stats, this.sharedEntryName));
-        const tmpEntryBootstrapFile = path.join(this.buildDir, getChunkFilename(stats, sharedEntryTmpName));
+        const sharedEntryOutputFile = getChunkFilename(compilation, this.sharedEntryName);
+        const tmpEntryFile = getChunkFilename(compilation, sharedEntryTmpName);
+        const assets = compilation.assets;
+
+        const sharedEntryAsset = assets[sharedEntryOutputFile];
+        const tmpEntryAsset = assets[tmpEntryFile];
 
-        if (!fs.existsSync(sharedEntryOutputFile)) {
+        if (typeof sharedEntryAsset === 'undefined') {
             throw new Error(`Could not find shared entry output file: ${sharedEntryOutputFile}`);
         }
 
-        if (!fs.existsSync(tmpEntryBootstrapFile)) {
-            throw new Error(`Could not find temporary shared entry bootstrap file: ${tmpEntryBootstrapFile}`);
+        if (typeof assets[tmpEntryFile] === 'undefined') {
+            throw new Error(`Could not find temporary shared entry bootstrap file: ${tmpEntryFile}`);
         }
 
-        fs.writeFileSync(
-            sharedEntryOutputFile,
-            [fs.readFileSync(sharedEntryOutputFile), fs.readFileSync(tmpEntryBootstrapFile)].join('\n')
+        assets[sharedEntryOutputFile] = new RawSource(
+            [getAssetSource(sharedEntryAsset), getAssetSource(tmpEntryAsset)].join('\n')
         );
 
-        fs.unlinkSync(tmpEntryBootstrapFile);
+        delete(assets[tmpEntryFile]);
     };
 
     compiler.hooks.emit.tap(

package.json

@@ -52,6 +52,7 @@
     "webpack-cli": "^3.0.0",
     "webpack-dev-server": "^3.1.4",
     "webpack-manifest-plugin": "^2.0.2",
+    "webpack-sources": "^1.3.0",
     "yargs": "^8.0.1"
   },
   "devDependencies": {