Skip to content

Groups option, missing #9557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Groups option, missing #9557

wants to merge 2 commits into from

Conversation

@goncziakos
Copy link

@goncziakos goncziakos commented Apr 5, 2018

No description provided.

@javiereguiluz
Copy link
Member

javiereguiluz commented Apr 18, 2018

@goncziakos thanks for your contribution! I'd like to find more details about this feature. Could you please share the link to the pull request that introduced this in Symfony? Thanks!

@javiereguiluz
Copy link
Member

javiereguiluz commented Apr 27, 2018

Ping @goncziakos. Could you please share some details about when this option was added to UniqueEntity? Thanks!

@wouterj
Copy link
Member

wouterj commented May 5, 2018

Hi @goncziakos! Looking at the description of this option, I think you might have confused it's naming with validation_groups. Are you sure it's called groups?

If you agree, please update this pull request so we can merge it.

@xabbuh
Copy link
Member

xabbuh commented May 18, 2018

I think @goncziakos indeed wants to describe the groups option which is defined by the base Constraint class and which we show, for example, in http://symfony.com/doc/current/validation/groups.html. However, this option is available in all constraints. So I think we should find a generic description and add it to all constraint reference pages.

@xabbuh xabbuh added this to the 2.7 milestone May 18, 2018
@javiereguiluz javiereguiluz modified the milestones: 2.7, 2.8 May 28, 2018
@xabbuh xabbuh modified the milestones: 2.8, 3.4 Nov 28, 2018
@javiereguiluz javiereguiluz mentioned this pull request Mar 6, 2019
Closed
javiereguiluz added a commit that referenced this pull request Mar 7, 2019
@javiereguiluz
minor #11092 Added the docs for the "groups" constraint option (javie…
56e73bb 
…reguiluz)

This PR was squashed before being merged into the 3.4 branch (closes #11092).

Discussion
----------

Added the docs for the "groups" constraint option

This continues #9557.

Question to reviewers: does this option apply to Valid and All constraints too?

Commits
-------

da9aa0e Added the docs for the \"groups\" constraint option
@javiereguiluz
Copy link
Member

javiereguiluz commented Mar 28, 2019

Closing as fixed by #11092.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Needs Work Validator

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@goncziakos @javiereguiluz @wouterj @xabbuh @carsonbot