minor #6472 Avoid confusion (gerryvdm)

weaverryan · weaverryan · commit 9db055c713e5 · 2016-04-26T12:46:00.000-04:00
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6472). Discussion ---------- Avoid confusion To me it was a bit confusing why the locale was set on the session and not the request. Further more, reading the linked article shows extra code is needed to make this work at all. Since the linked article explains in more detail how to make the locale sticky, I suggest just setting it on the request in this code sample. Commits ------- 6818b8e Avoid confusion
diff --git a/book/translation.rst b/book/translation.rst
@@ -432,7 +432,7 @@ need it::
             $request = $event->getRequest();
 
             // some logic to determine the $locale
-            $request->getSession()->set('_locale', $locale);
+            $request->setLocale($locale);
         }
 
 Read :doc:`/cookbook/session/locale_sticky_session` for more on the topic.

Original file line number	Diff line number	Diff line change
`@@ -432,7 +432,7 @@ need it::`
`432`	`432`	`$request = $event->getRequest();`
`433`	`433`
`434`	`434`	`// some logic to determine the $locale`
`435`		`- $request->getSession()->set('_locale', $locale);`
	`435`	`+ $request->setLocale($locale);`
`436`	`436`	`}`
`437`	`437`
`438`	`438`	Read :doc:`/cookbook/session/locale_sticky_session` for more on the topic.