minor #16985 Adding that you cannot access a session inside a constructor (ThomasLandauer)

wouterj · wouterj · commit 52d1c559c7b3 · 2022-08-23T17:52:01.000+02:00
This PR was submitted for the 6.1 branch but it was squashed and merged into the 5.4 branch instead. Discussion ---------- Adding that you cannot access a session inside a constructor Please double-check! The info is taken from PhpStorm's Symfony Plugin: https://espend.de/phpstorm/plugin/symfony#inspections: > A Session must not be used inside a constructor I think this should be explained here, since doing `$this->session = $requestStack->getSession();` right in the constructor looked like a nice idea... Commits ------- 9f3b147 Adding that you cannot access a session inside a constructor
diff --git a/session.rst b/session.rst
@@ -149,6 +149,10 @@ if you type-hint an argument with :class:`Symfony\\Component\\HttpFoundation\\Re
         public function __construct(RequestStack $requestStack)
         {
             $this->requestStack = $requestStack;
+
+            // Accessing the session in the constructor is *NOT* reommended, since
+            // it might not be accessible yet or lead to unwanted side-effects
+            // $this->session = $requestStack->getSession();
         }
 
         public function someMethod()

Original file line number	Diff line number	Diff line change
@@ -149,6 +149,10 @@ if you type-hint an argument with :class:`Symfony\\Component\\HttpFoundation\\Re
`149`	`149`	`public function __construct(RequestStack $requestStack)`
`150`	`150`	`{`
`151`	`151`	`$this->requestStack = $requestStack;`
	`152`	`+`
	`153`	`+ // Accessing the session in the constructor is NOT reommended, since`
	`154`	`+ // it might not be accessible yet or lead to unwanted side-effects`
	`155`	`+ // $this->session = $requestStack->getSession();`
`152`	`156`	`}`
`153`	`157`
`154`	`158`	`public function someMethod()`