Merge branch '2.8' into 3.4

* 2.8:
  {% if label is not same as(false) and required %}
  Shorten ternary operator
  Fix wrong usage in custom authenticator checking if password is invalid
  update hardcoded 5.1 version link
  Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
  Update bugs.rst
  [#10200] remove trailing spaces
  action_method is missing $task variable
  Fix bad link

Author: weaverryan

components/finder.rst

@@ -171,6 +171,14 @@ Sort the result by name or by type (directories first, then files)::
 
     $finder->sortByType();
 
+Sort the files and directories by the last accessed, changed or modified time::
+
+    $finder->sortByAccessedTime();
+
+    $finder->sortByChangedTime();
+
+    $finder->sortByModifiedTime();
+
 .. note::
 
     Notice that the ``sort*`` methods need to get all matching elements to do

contributing/code/bugs.rst

@@ -44,7 +44,7 @@ If your problem definitely looks like a bug, report it using the official bug
 
 * *(optional)* Attach a :doc:`patch <patches>`.
 
-.. _`Stack Overflow`: https://stackoverflow.com/questions/tagged/symfony2
+.. _`Stack Overflow`: https://stackoverflow.com/questions/tagged/symfony
 .. _IRC channel: https://symfony.com/irc
 .. _the Symfony Slack: https://symfony.com/slack-invite
 .. _tracker: https://github.com/symfony/symfony/issues

create_framework/front_controller.rst

@@ -153,7 +153,7 @@ web root directory:
 Now, configure your web server root directory to point to ``web/`` and all
 other files won't be accessible from the client anymore.
 
-To test your changes in a browser (``http://localhost:4321/hello/?name=Fabien``), run
+To test your changes in a browser (``http://localhost:4321/hello?name=Fabien``), run
 the PHP built-in server:
 
 .. code-block:: terminal

form/action_method.rst

@@ -27,6 +27,8 @@ form, you can use ``setAction()`` and ``setMethod()``:
         {
             public function newAction()
             {
+                // ...
+
                 $form = $this->createFormBuilder($task)
                     ->setAction($this->generateUrl('target_route'))
                     ->setMethod('GET')

form/form_customization.rst

@@ -755,7 +755,7 @@ form, modify the ``use`` tag and add the following:
     {% block form_label %}
         {{ block('base_form_label') }}
 
-        {% if required %}
+        {% if label is not same as(false) and required %}
             <span class="required" title="This field is required">*</span>
         {% endif %}
     {% endblock %}
@@ -770,7 +770,7 @@ the following:
     {% block form_label %}
         {{ parent() }}
 
-        {% if required %}
+        {% if label is not same as(false) and required %}
             <span class="required" title="This field is required">*</span>
         {% endif %}
     {% endblock %}

reference/forms/twig_reference.rst

@@ -322,7 +322,7 @@ done by using a public ``vars`` property on the
 .. code-block:: html+twig
 
     <label for="{{ form.name.vars.id }}"
-        class="{{ form.name.vars.required ? 'required' : '' }}">
+        class="{{ form.name.vars.required ? 'required' }}">
         {{ form.name.vars.label }}
     </label>
 

security/custom_password_authenticator.rst

@@ -63,7 +63,7 @@ the user::
                 if ('' === ($givenPassword = $token->getCredentials())) {
                     throw new BadCredentialsException('The given password cannot be empty.');
                 }
-                if (!$this->encoder->isPasswordValid($user->getPassword(), $givenPassword, $user->getSalt())) {
+                if (!$this->encoder->isPasswordValid($user, $givenPassword)) {
                     throw new BadCredentialsException('The given password is invalid.');
                 }
             }

setup/homestead.rst

@@ -72,5 +72,5 @@ developing your Symfony application!
 .. _Homestead: https://laravel.com/docs/homestead
 .. _Vagrant: https://www.vagrantup.com/
 .. _the Homestead documentation: https://laravel.com/docs/homestead#installation-and-setup
-.. _Daily Usage: https://laravel.com/docs/5.1/homestead#daily-usage
+.. _Daily Usage: https://laravel.com/docs/homestead#daily-usage
 .. _this blog post: https://www.whitewashing.de/2013/08/19/speedup_symfony2_on_vagrant_boxes.html