Commit 404ed93
committed
minor #5652 Do not use dynamic REQUEST_URI from $_SERVER as base url (senkal)
This PR was merged into the 2.3 branch.
Discussion
----------
Do not use dynamic REQUEST_URI from $_SERVER as base url
| Q | A
| ------------- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | 2.3
| Fixed tickets |
I am not sure why we use `$_SERVER['REQUEST_URI']` as a first parameter for `Symfony\Component\Routing\RequestContext` where it expects to get baseUrl.
`$_SERVER['REQUEST_URI'] ` is dynamic and shouldn't be used as a static value for baseUrl.
Probably better not to pass this parameter at all(default) or use `/`, what I propose.
I know that many people won't look that deeply into those examples but, in my opinion, `$_SERVER['REQUEST_URI'] ` is not base url.
Not sure what to do with the note about the request uri(the one with http foundation link/info).
Maybe the idea was to use `$_SERVER['REQUEST_URI']` in `->match()` examples ?
Commits
-------
dadefb6 Od not use dynamic REQUEST_URI from $_SERVER as base url1 file changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
210 | | - | |
| 210 | + | |
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
| |||
327 | 327 | | |
328 | 328 | | |
329 | 329 | | |
330 | | - | |
| 330 | + | |
331 | 331 | | |
332 | 332 | | |
333 | 333 | | |
| |||
0 commit comments