Commit 3e8aa59
committed
minor #4376 Cleaned up javascript code (flip111)
This PR was squashed before being merged into the 2.3 branch (closes #4376).
Discussion
----------
Cleaned up javascript code
| Q | A
| ------------- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | 2.3
| Fixed tickets | n/a
1. Reused variable `emailList` which is best practice and easier to read
2. Removed `return false`. There is no use for it in this context and many consider it to be bad use as well. For example: http://fuelyourcoding.com/jquery-events-stop-misusing-return-false/
Commits
-------
8931249 Cleaned up javascript code1 file changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
182 | | - | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
183 | 185 | | |
184 | 186 | | |
185 | 187 | | |
| |||
192 | 194 | | |
193 | 195 | | |
194 | 196 | | |
195 | | - | |
196 | | - | |
197 | | - | |
| 197 | + | |
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
| |||
0 commit comments