Commit 13870bc
committed
minor #8621 Path package in context aware (takman1)
This PR was merged into the 3.3 branch.
Discussion
----------
Path package in context aware
How to reproduce :
- Application has a base url (/some-base-url)
- Using "PathPackage"
- Using RequestStackContext (3rd parameter),
- getUrl of asset with absolute path.
Result :
Both "base url" of application and "base path" of PathPackage are ignored.
Example :
Application base url : /some-prefix
$package = new PathPackage('/static/', new StaticVersionStrategy('v1.2'), new RequestStackContext($requestStack));
echo $package->getUrl("/img.png"); // /img.png?v1.2
Check merged PR #8574.
NB : Maybe there a conception problem in Asset component. I my opinion only "base path" should be ignored but "base url" should always be used to prefix the generated asset path.
Commits
-------
0dbb635 Path package in context aware1 file changed
+6
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
208 | | - | |
| 207 | + | |
| 208 | + | |
209 | 209 | | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
210 | 214 | | |
211 | 215 | | |
212 | 216 | | |
| |||
0 commit comments