Remove calls to getMockForAbstractClass()

Author: alexandre-daubois

Tests/Authentication/Provider/UserAuthenticationProviderTest.php

@@ -250,6 +250,9 @@ protected function getProvider($userChecker = false, $hide = true)
             $userChecker = $this->createMock(UserCheckerInterface::class);
         }
 
-        return $this->getMockForAbstractClass(UserAuthenticationProvider::class, [$userChecker, 'key', $hide]);
+        return $this->getMockBuilder(UserAuthenticationProvider::class)
+            ->setConstructorArgs([$userChecker, 'key', $hide])
+            ->onlyMethods(['retrieveUser', 'checkAuthentication'])
+            ->getMock();
     }
 }

Tests/Authorization/AccessDecisionManagerTest.php

@@ -179,7 +179,8 @@ public static function getStrategyTests(): array
     public function testCacheableVoters()
     {
         $token = $this->createMock(TokenInterface::class);
-        $voter = $this->getMockBuilder(CacheableVoterInterface::class)->getMockForAbstractClass();
+        $voter = $this->createMock(CacheableVoterInterface::class);
+
         $voter
             ->expects($this->once())
             ->method('supportsAttribute')
@@ -203,7 +204,7 @@ public function testCacheableVoters()
     public function testCacheableVotersIgnoresNonStringAttributes()
     {
         $token = $this->createMock(TokenInterface::class);
-        $voter = $this->getMockBuilder(CacheableVoterInterface::class)->getMockForAbstractClass();
+        $voter = $this->createMock(CacheableVoterInterface::class);
         $voter
             ->expects($this->never())
             ->method('supportsAttribute');
@@ -225,7 +226,7 @@ public function testCacheableVotersIgnoresNonStringAttributes()
     public function testCacheableVotersWithMultipleAttributes()
     {
         $token = $this->createMock(TokenInterface::class);
-        $voter = $this->getMockBuilder(CacheableVoterInterface::class)->getMockForAbstractClass();
+        $voter = $this->createMock(CacheableVoterInterface::class);
         $voter
             ->expects($this->exactly(2))
             ->method('supportsAttribute')
@@ -258,7 +259,7 @@ public function testCacheableVotersWithMultipleAttributes()
     public function testCacheableVotersWithEmptyAttributes()
     {
         $token = $this->createMock(TokenInterface::class);
-        $voter = $this->getMockBuilder(CacheableVoterInterface::class)->getMockForAbstractClass();
+        $voter = $this->createMock(CacheableVoterInterface::class);
         $voter
             ->expects($this->never())
             ->method('supportsAttribute');
@@ -280,7 +281,7 @@ public function testCacheableVotersWithEmptyAttributes()
     public function testCacheableVotersSupportsMethodsCalledOnce()
     {
         $token = $this->createMock(TokenInterface::class);
-        $voter = $this->getMockBuilder(CacheableVoterInterface::class)->getMockForAbstractClass();
+        $voter = $this->createMock(CacheableVoterInterface::class);
         $voter
             ->expects($this->once())
             ->method('supportsAttribute')
@@ -305,7 +306,7 @@ public function testCacheableVotersSupportsMethodsCalledOnce()
     public function testCacheableVotersNotCalled()
     {
         $token = $this->createMock(TokenInterface::class);
-        $voter = $this->getMockBuilder(CacheableVoterInterface::class)->getMockForAbstractClass();
+        $voter = $this->createMock(CacheableVoterInterface::class);
         $voter
             ->expects($this->once())
             ->method('supportsAttribute')
@@ -325,7 +326,7 @@ public function testCacheableVotersNotCalled()
     public function testCacheableVotersWithMultipleAttributesAndNonString()
     {
         $token = $this->createMock(TokenInterface::class);
-        $voter = $this->getMockBuilder(CacheableVoterInterface::class)->getMockForAbstractClass();
+        $voter = $this->createMock(CacheableVoterInterface::class);
         $voter
             ->expects($this->once())
             ->method('supportsAttribute')

Tests/Authorization/Voter/TraceableVoterTest.php

@@ -23,18 +23,18 @@ class TraceableVoterTest extends TestCase
 {
     public function testGetDecoratedVoterClass()
     {
-        $voter = $this->getMockBuilder(VoterInterface::class)->getMockForAbstractClass();
+        $voter = $this->createStub(VoterInterface::class);
 
-        $sut = new TraceableVoter($voter, $this->getMockBuilder(EventDispatcherInterface::class)->getMockForAbstractClass());
+        $sut = new TraceableVoter($voter, $this->createStub(EventDispatcherInterface::class));
         $this->assertSame($voter, $sut->getDecoratedVoter());
     }
 
     public function testVote()
     {
-        $voter = $this->getMockBuilder(VoterInterface::class)->getMockForAbstractClass();
+        $voter = $this->createMock(VoterInterface::class);
 
-        $eventDispatcher = $this->getMockBuilder(EventDispatcherInterface::class)->getMockForAbstractClass();
-        $token = $this->getMockBuilder(TokenInterface::class)->getMockForAbstractClass();
+        $eventDispatcher = $this->createMock(EventDispatcherInterface::class);
+        $token = $this->createStub(TokenInterface::class);
 
         $voter
             ->expects($this->once())
@@ -55,8 +55,8 @@ public function testVote()
 
     public function testSupportsAttributeOnCacheable()
     {
-        $voter = $this->getMockBuilder(CacheableVoterInterface::class)->getMockForAbstractClass();
-        $eventDispatcher = $this->getMockBuilder(EventDispatcherInterface::class)->getMockForAbstractClass();
+        $voter = $this->createMock(CacheableVoterInterface::class);
+        $eventDispatcher = $this->createStub(EventDispatcherInterface::class);
 
         $voter
             ->expects($this->once())
@@ -71,8 +71,8 @@ public function testSupportsAttributeOnCacheable()
 
     public function testSupportsTypeOnCacheable()
     {
-        $voter = $this->getMockBuilder(CacheableVoterInterface::class)->getMockForAbstractClass();
-        $eventDispatcher = $this->getMockBuilder(EventDispatcherInterface::class)->getMockForAbstractClass();
+        $voter = $this->createMock(CacheableVoterInterface::class);
+        $eventDispatcher = $this->createStub(EventDispatcherInterface::class);
 
         $voter
             ->expects($this->once())
@@ -87,8 +87,8 @@ public function testSupportsTypeOnCacheable()
 
     public function testSupportsAttributeOnNonCacheable()
     {
-        $voter = $this->getMockBuilder(VoterInterface::class)->getMockForAbstractClass();
-        $eventDispatcher = $this->getMockBuilder(EventDispatcherInterface::class)->getMockForAbstractClass();
+        $voter = $this->createStub(VoterInterface::class);
+        $eventDispatcher = $this->createStub(EventDispatcherInterface::class);
 
         $sut = new TraceableVoter($voter, $eventDispatcher);
 
@@ -97,8 +97,8 @@ public function testSupportsAttributeOnNonCacheable()
 
     public function testSupportsTypeOnNonCacheable()
     {
-        $voter = $this->getMockBuilder(VoterInterface::class)->getMockForAbstractClass();
-        $eventDispatcher = $this->getMockBuilder(EventDispatcherInterface::class)->getMockForAbstractClass();
+        $voter = $this->createStub(VoterInterface::class);
+        $eventDispatcher = $this->createStub(EventDispatcherInterface::class);
 
         $sut = new TraceableVoter($voter, $eventDispatcher);
 

Tests/User/ChainUserProviderTest.php

@@ -252,14 +252,14 @@ public function testPasswordUpgrades()
     {
         $user = new InMemoryUser('user', 'pwd');
 
-        $provider1 = $this->getMockForAbstractClass(MigratingProvider::class);
+        $provider1 = $this->createMock(MigratingProvider::class);
         $provider1
             ->expects($this->once())
             ->method('upgradePassword')
             ->willThrowException(new UnsupportedUserException('unsupported'))
         ;
 
-        $provider2 = $this->getMockForAbstractClass(MigratingProvider::class);
+        $provider2 = $this->createMock(MigratingProvider::class);
         $provider2
             ->expects($this->once())
             ->method('upgradePassword')