Merge branch '4.4' into 5.1

* 4.4:
  Update .php_cs.dist
  Apply "visibility_required" CS rule to constants

Author: nicolas-grekas

Authentication/Provider/AuthenticationProviderInterface.php

@@ -29,7 +29,7 @@ interface AuthenticationProviderInterface extends AuthenticationManagerInterface
      *
      * @var string
      */
-    const USERNAME_NONE_PROVIDED = 'NONE_PROVIDED';
+    public const USERNAME_NONE_PROVIDED = 'NONE_PROVIDED';
 
     /**
      * Checks whether this provider supports the given token.

AuthenticationEvents.php

@@ -19,13 +19,13 @@ final class AuthenticationEvents
      *
      * @Event("Symfony\Component\Security\Core\Event\AuthenticationSuccessEvent")
      */
-    const AUTHENTICATION_SUCCESS = 'security.authentication.success';
+    public const AUTHENTICATION_SUCCESS = 'security.authentication.success';
 
     /**
      * The AUTHENTICATION_FAILURE event occurs after a user cannot be
      * authenticated by any of the providers.
      *
      * @Event("Symfony\Component\Security\Core\Event\AuthenticationFailureEvent")
      */
-    const AUTHENTICATION_FAILURE = 'security.authentication.failure';
+    public const AUTHENTICATION_FAILURE = 'security.authentication.failure';
 }

Authorization/AccessDecisionManager.php

@@ -23,10 +23,10 @@
  */
 class AccessDecisionManager implements AccessDecisionManagerInterface
 {
-    const STRATEGY_AFFIRMATIVE = 'affirmative';
-    const STRATEGY_CONSENSUS = 'consensus';
-    const STRATEGY_UNANIMOUS = 'unanimous';
-    const STRATEGY_PRIORITY = 'priority';
+    public const STRATEGY_AFFIRMATIVE = 'affirmative';
+    public const STRATEGY_CONSENSUS = 'consensus';
+    public const STRATEGY_UNANIMOUS = 'unanimous';
+    public const STRATEGY_PRIORITY = 'priority';
 
     private $voters;
     private $strategy;

Authorization/Voter/AuthenticatedVoter.php

@@ -26,12 +26,12 @@
  */
 class AuthenticatedVoter implements VoterInterface
 {
-    const IS_AUTHENTICATED_FULLY = 'IS_AUTHENTICATED_FULLY';
-    const IS_AUTHENTICATED_REMEMBERED = 'IS_AUTHENTICATED_REMEMBERED';
-    const IS_AUTHENTICATED_ANONYMOUSLY = 'IS_AUTHENTICATED_ANONYMOUSLY';
-    const IS_ANONYMOUS = 'IS_ANONYMOUS';
-    const IS_IMPERSONATOR = 'IS_IMPERSONATOR';
-    const IS_REMEMBERED = 'IS_REMEMBERED';
+    public const IS_AUTHENTICATED_FULLY = 'IS_AUTHENTICATED_FULLY';
+    public const IS_AUTHENTICATED_REMEMBERED = 'IS_AUTHENTICATED_REMEMBERED';
+    public const IS_AUTHENTICATED_ANONYMOUSLY = 'IS_AUTHENTICATED_ANONYMOUSLY';
+    public const IS_ANONYMOUS = 'IS_ANONYMOUS';
+    public const IS_IMPERSONATOR = 'IS_IMPERSONATOR';
+    public const IS_REMEMBERED = 'IS_REMEMBERED';
 
     private $authenticationTrustResolver;
 

Authorization/Voter/VoterInterface.php

@@ -20,9 +20,9 @@
  */
 interface VoterInterface
 {
-    const ACCESS_GRANTED = 1;
-    const ACCESS_ABSTAIN = 0;
-    const ACCESS_DENIED = -1;
+    public const ACCESS_GRANTED = 1;
+    public const ACCESS_ABSTAIN = 0;
+    public const ACCESS_DENIED = -1;
 
     /**
      * Returns the vote for the given parameters.

Encoder/BasePasswordEncoder.php

@@ -18,7 +18,7 @@
  */
 abstract class BasePasswordEncoder implements PasswordEncoderInterface
 {
-    const MAX_PASSWORD_LENGTH = 4096;
+    public const MAX_PASSWORD_LENGTH = 4096;
 
     /**
      * {@inheritdoc}

Security.php

@@ -22,10 +22,10 @@
  */
 class Security
 {
-    const ACCESS_DENIED_ERROR = '_security.403_error';
-    const AUTHENTICATION_ERROR = '_security.last_error';
-    const LAST_USERNAME = '_security.last_username';
-    const MAX_USERNAME_LENGTH = 4096;
+    public const ACCESS_DENIED_ERROR = '_security.403_error';
+    public const AUTHENTICATION_ERROR = '_security.last_error';
+    public const LAST_USERNAME = '_security.last_username';
+    public const MAX_USERNAME_LENGTH = 4096;
 
     private $container;