use constructor property promotion

Author: xabbuh

Exception/ProcessFailedException.php

@@ -20,10 +20,9 @@
  */
 class ProcessFailedException extends RuntimeException
 {
-    private Process $process;
-
-    public function __construct(Process $process)
-    {
+    public function __construct(
+        private Process $process,
+    ) {
         if ($process->isSuccessful()) {
             throw new InvalidArgumentException('Expected a failed process, but the given process was successful.');
         }

Exception/ProcessSignaledException.php

@@ -20,12 +20,9 @@
  */
 final class ProcessSignaledException extends RuntimeException
 {
-    private Process $process;
-
-    public function __construct(Process $process)
-    {
-        $this->process = $process;
-
+    public function __construct(
+        private Process $process,
+    ) {
         parent::__construct(sprintf('The process has been signaled with signal "%s".', $process->getTermSignal()));
     }
 

Exception/ProcessStartFailedException.php

@@ -18,10 +18,10 @@
  */
 class ProcessStartFailedException extends ProcessFailedException
 {
-    private Process $process;
-
-    public function __construct(Process $process, ?string $message)
-    {
+    public function __construct(
+        private Process $process,
+        ?string $message,
+    ) {
         if ($process->isStarted()) {
             throw new InvalidArgumentException('Expected a process that failed during startup, but the given process was started successfully.');
         }
@@ -34,8 +34,6 @@ public function __construct(Process $process, ?string $message)
 
         // Skip parent constructor
         RuntimeException::__construct($error);
-
-        $this->process = $process;
     }
 
     public function getProcess(): Process

Exception/ProcessTimedOutException.php

@@ -23,14 +23,10 @@ class ProcessTimedOutException extends RuntimeException
     public const TYPE_GENERAL = 1;
     public const TYPE_IDLE = 2;
 
-    private Process $process;
-    private int $timeoutType;
-
-    public function __construct(Process $process, int $timeoutType)
-    {
-        $this->process = $process;
-        $this->timeoutType = $timeoutType;
-
+    public function __construct(
+        private Process $process,
+        private int $timeoutType,
+    ) {
         parent::__construct(sprintf(
             'The process "%s" exceeded the timeout of %s seconds.',
             $process->getCommandLine(),

Pipes/UnixPipes.php

@@ -22,16 +22,12 @@
  */
 class UnixPipes extends AbstractPipes
 {
-    private ?bool $ttyMode;
-    private bool $ptyMode;
-    private bool $haveReadSupport;
-
-    public function __construct(?bool $ttyMode, bool $ptyMode, mixed $input, bool $haveReadSupport)
-    {
-        $this->ttyMode = $ttyMode;
-        $this->ptyMode = $ptyMode;
-        $this->haveReadSupport = $haveReadSupport;
-
+    public function __construct(
+        private ?bool $ttyMode,
+        private bool $ptyMode,
+        mixed $input,
+        private bool $haveReadSupport,
+    ) {
         parent::__construct($input);
     }
 

Pipes/WindowsPipes.php

@@ -33,12 +33,11 @@ class WindowsPipes extends AbstractPipes
         Process::STDOUT => 0,
         Process::STDERR => 0,
     ];
-    private bool $haveReadSupport;
-
-    public function __construct(mixed $input, bool $haveReadSupport)
-    {
-        $this->haveReadSupport = $haveReadSupport;
 
+    public function __construct(
+        mixed $input,
+        private bool $haveReadSupport,
+    ) {
         if ($this->haveReadSupport) {
             // Fix for PHP bug #51800: reading from STDOUT pipe hangs forever on Windows if the output is too big.
             // Workaround for this problem is to use temporary files instead of pipes on Windows platform.