Merge branch '7.4' into 8.0

* 7.4:
  Use phpunit attribute
  Remove some implicit bool type juggling
  [Scheduler] Fix `scheduler.task` tag arguments optionality
  use false instead of null to hide the currency symbol
  [FrameworkBundle] Fix block type from `OK` to `ERROR` when local vault is disabled in `SecretsRemoveCommand`
  run tests with PHPUnit 12.1 on PHP >= 8.3
  Fix wrong boolean values
  minor #61328 [FrameworkBundle] Decouple ControllerResolverTest from HttpKernel (nicolas-grekas)
  [Messenger] Fix NoAutoAckStamp handling in Worker::flush()
  [DependencyInjection] Dump XML using plain PHP, no DOM needed

Author: nicolas-grekas

ExecutableFinder.php

@@ -63,13 +63,13 @@ public function find(string $name, ?string $default = null, array $extraDirs = [
         }
 
         $dirs = array_merge(
-            explode(\PATH_SEPARATOR, getenv('PATH') ?: getenv('Path')),
+            explode(\PATH_SEPARATOR, getenv('PATH') ?: getenv('Path') ?: ''),
             $extraDirs
         );
 
         $suffixes = $this->suffixes;
         if ('\\' === \DIRECTORY_SEPARATOR) {
-            $pathExt = getenv('PATHEXT');
+            $pathExt = getenv('PATHEXT') ?: '';
             $suffixes = array_merge($suffixes, $pathExt ? explode(\PATH_SEPARATOR, $pathExt) : ['.exe', '.bat', '.cmd', '.com']);
         }
         $suffixes = '' !== pathinfo($name, \PATHINFO_EXTENSION) ? array_merge([''], $suffixes) : array_merge($suffixes, ['']);

Pipes/AbstractPipes.php

@@ -72,10 +72,10 @@ protected function unblock(): void
         }
 
         foreach ($this->pipes as $pipe) {
-            stream_set_blocking($pipe, 0);
+            stream_set_blocking($pipe, false);
         }
         if (\is_resource($this->input)) {
-            stream_set_blocking($this->input, 0);
+            stream_set_blocking($this->input, false);
         }
 
         $this->blocked = false;
@@ -97,7 +97,7 @@ protected function write(): ?array
             if (!$input->valid()) {
                 $input = null;
             } elseif (\is_resource($input = $input->current())) {
-                stream_set_blocking($input, 0);
+                stream_set_blocking($input, false);
             } elseif (!isset($this->inputBuffer[0])) {
                 if (!\is_string($input)) {
                     if (!\is_scalar($input)) {

Tests/ExecutableFinderTest.php

@@ -14,6 +14,7 @@
 use PHPUnit\Framework\Attributes\RunInSeparateProcess;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Process\ExecutableFinder;
+use Symfony\Component\Process\Process;
 
 /**
  * @author Chris Smith <chris@cs278.org>
@@ -122,17 +123,11 @@ public function testFindWithOpenBaseDir()
             $this->markTestSkipped('Cannot test when open_basedir is set');
         }
 
-        putenv('PATH='.\dirname(\PHP_BINARY));
-        $initialOpenBaseDir = ini_set('open_basedir', \dirname(\PHP_BINARY).\PATH_SEPARATOR.'/');
-
-        try {
-            $finder = new ExecutableFinder();
-            $result = $finder->find($this->getPhpBinaryName());
+        $process = new Process([\PHP_BINARY, '-d', 'open_basedir='.\dirname(\PHP_BINARY).\PATH_SEPARATOR.'/', __DIR__.'/Fixtures/open_basedir.php']);
+        $process->run();
+        $result = $process->getOutput();
 
-            $this->assertSamePath(\PHP_BINARY, $result);
-        } finally {
-            ini_set('open_basedir', $initialOpenBaseDir);
-        }
+        $this->assertSamePath(\PHP_BINARY, $result);
     }
 
     #[RunInSeparateProcess]

Tests/Fixtures/open_basedir.php

@@ -0,0 +1,23 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+require_once __DIR__.'/../../ExecutableFinder.php';
+
+use Symfony\Component\Process\ExecutableFinder;
+
+putenv('PATH='.dirname(PHP_BINARY));
+
+function getPhpBinaryName(): string
+{
+    return basename(PHP_BINARY, '\\' === DIRECTORY_SEPARATOR ? '.exe' : '');
+}
+
+echo (new ExecutableFinder())->find(getPhpBinaryName());

Tests/PipeStdinInStdoutStdErrStreamSelect.php

@@ -17,9 +17,9 @@
 $read = [\STDIN];
 $write = [\STDOUT, \STDERR];
 
-stream_set_blocking(\STDIN, 0);
-stream_set_blocking(\STDOUT, 0);
-stream_set_blocking(\STDERR, 0);
+stream_set_blocking(\STDIN, false);
+stream_set_blocking(\STDOUT, false);
+stream_set_blocking(\STDERR, false);
 
 $out = $err = '';
 while ($read || $write) {