replace uniqid() with random_bytes() to create identifiers

xabbuh · xabbuh · commit bb0a8b777261 · 2024-07-29T08:33:22.000+02:00
diff --git a/Process.php b/Process.php
@@ -1543,7 +1543,7 @@ private function buildShellCommandline(string|array $commandline): string
     private function prepareWindowsCommandLine(string|array $cmd, array &$env): string
     {
         $cmd = $this->buildShellCommandline($cmd);
-        $uid = uniqid('', true);
+        $uid = bin2hex(random_bytes(4));
         $cmd = preg_replace_callback(
             '/"(?:(
                 [^"%!^]*+

Original file line number	Diff line number	Diff line change
`@@ -1543,7 +1543,7 @@ private function buildShellCommandline(string\|array $commandline): string`
`1543`	`1543`	`private function prepareWindowsCommandLine(string\|array $cmd, array &$env): string`
`1544`	`1544`	`{`
`1545`	`1545`	`$cmd = $this->buildShellCommandline($cmd);`
`1546`		`- $uid = uniqid('', true);`
	`1546`	`+ $uid = bin2hex(random_bytes(4));`
`1547`	`1547`	`$cmd = preg_replace_callback(`
`1548`	`1548`	`'/"(?:(`
`1549`	`1549`	`[^"%!^]*+`