Merge branch '5.4' into 6.2

* 5.4:
  [FrameworkBundle] Fix Workflow without a marking store definition uses marking store definition of previously defined workflow
  [HttpFoundation] UrlHelper is now aware of RequestContext changes
  UrlHelper is now aware of RequestContext changes
  [Process] Stop the process correctly even if underlying input stream is not closed:
  [Notifier] Update AmazonSns url in doc from de to en
  [PropertyInfo] Fix `PhpStanExtractor` when constructor has no docblock

Author: nicolas-grekas

Process.php

@@ -421,7 +421,7 @@ public function wait(callable $callback = null): int
 
         do {
             $this->checkTimeout();
-            $running = '\\' === \DIRECTORY_SEPARATOR ? $this->isRunning() : $this->processPipes->areOpen();
+            $running = $this->isRunning() && ('\\' === \DIRECTORY_SEPARATOR || $this->processPipes->areOpen());
             $this->readPipes($running, '\\' !== \DIRECTORY_SEPARATOR || !$running);
         } while ($running);
 

Tests/ProcessTest.php

@@ -1536,6 +1536,16 @@ public function testEnvCaseInsensitiveOnWindows()
         }
     }
 
+    public function testNotTerminableInputPipe()
+    {
+        $process = $this->getProcess('echo foo');
+        $process->setInput(\STDIN);
+        $process->start();
+        $process->setTimeout(2);
+        $process->wait();
+        $this->assertFalse($process->isRunning());
+    }
+
     /**
      * @param string|array $commandline
      * @param mixed        $input