Skip to content

Commit 8b07800

Browse files
authored
Make the CI green again (#681)
* make PHPStan happy * fix PHPUnit 10 installation * fix the code style
1 parent b7e0f83 commit 8b07800

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
tools: php-cs-fixer, cs2pr
2020

2121
- name: PHP Coding Standards Fixer
22-
run: php-cs-fixer fix --dry-run --format checkstyle | cs2pr
22+
run: php-cs-fixer fix --dry-run --diff
2323

2424
phpstan:
2525
runs-on: ubuntu-latest
@@ -190,8 +190,8 @@ jobs:
190190
- name: Remove phpunit-bridge dependency (not yet PHPUnit 10+ compliant)
191191
run: composer remove --dev symfony/phpunit-bridge
192192

193-
- name: Install latest PHPUnit 11
194-
run: composer require --dev --prefer-dist 'phpunit/phpunit:>=10'
193+
- name: Install latest PHPUnit 10
194+
run: composer require --dev --prefer-dist 'phpunit/phpunit:10.5.*'
195195

196196
- name: Run tests
197197
run: vendor/bin/phpunit --configuration phpunit.xml.dist.10

src/PantherTestCaseTrait.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ protected static function createPantherClient(array $options = [], array $kernel
203203
}
204204
}
205205

206+
/* @phpstan-ignore-next-line */
206207
if (is_a(self::class, KernelTestCase::class, true)) {
207208
static::bootKernel($kernelOptions); // @phpstan-ignore-line
208209
}
@@ -247,6 +248,7 @@ protected static function createHttpBrowserClient(array $options = [], array $ke
247248
self::$httpBrowserClient = new HttpBrowserClient(HttpClient::create($httpClientOptions));
248249
}
249250

251+
/* @phpstan-ignore-next-line */
250252
if (is_a(self::class, KernelTestCase::class, true)) {
251253
static::bootKernel($kernelOptions); // @phpstan-ignore-line
252254
}

tests/ClientTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,8 +282,7 @@ public function testExecuteAsyncScript(): void
282282
const t = document.querySelector(parentArgs[0]).innerText;
283283
callback(t);
284284
}, 100, arguments);
285-
JS
286-
, ['.p-1']);
285+
JS, ['.p-1']);
287286

288287
$this->assertSame('P1', $innerText);
289288
}

0 commit comments

Comments
 (0)