Merge branch '4.4' into 5.0

* 4.4:
  Add missing dots at the end of exception messages
  [DI][Form] Fixed test suite (TimeType changes & unresolved merge conflict)
  Fix bad merge
  Add missing dots at the end of exception messages

Author: fabpot

Data/Bundle/Compiler/GenrbCompiler.php

@@ -37,7 +37,7 @@ public function __construct(string $genrb = 'genrb', string $envVars = '')
         exec('which '.$genrb, $output, $status);
 
         if (0 !== $status) {
-            throw new RuntimeException(sprintf('The command "%s" is not installed', $genrb));
+            throw new RuntimeException(sprintf('The command "%s" is not installed.', $genrb));
         }
 
         $this->genrb = ($envVars ? $envVars.' ' : '').$genrb;

Data/Bundle/Reader/JsonBundleReader.php

@@ -46,7 +46,7 @@ public function read(string $path, string $locale)
         $data = json_decode(file_get_contents($fileName), true);
 
         if (null === $data) {
-            throw new RuntimeException(sprintf('The resource bundle "%s" contains invalid JSON: %s', $fileName, json_last_error_msg()));
+            throw new RuntimeException(sprintf('The resource bundle "%s" contains invalid JSON: %s.', $fileName, json_last_error_msg()));
         }
 
         return $data;

Data/Generator/LocaleDataGenerator.php

@@ -165,7 +165,7 @@ private function generateLocaleName(BundleEntryReaderInterface $reader, string $
         // i.e. in de_AT, "AT" is the region
         if ($region = \Locale::getRegion($locale)) {
             if (ctype_alpha($region) && !RegionDataGenerator::isValidCountryCode($region)) {
-                throw new MissingResourceException('Skipping "'.$locale.'" due an invalid country.');
+                throw new MissingResourceException(sprintf('Skipping "%s" due an invalid country.', $locale));
             }
 
             $extras[] = str_replace(['(', ')'], ['[', ']'], $reader->readEntry($tempDir.'/region', $displayLocale, ['Countries', $region]));

DateFormatter/DateFormat/FullTransformer.php

@@ -104,7 +104,7 @@ private function formatReplace(string $dateChars, \DateTime $dateTime): string
 
         // handle unimplemented characters
         if (false !== strpos($this->notImplementedChars, $dateChars[0])) {
-            throw new NotImplementedException(sprintf('Unimplemented date character "%s" in format "%s"', $dateChars[0], $this->pattern));
+            throw new NotImplementedException(sprintf('Unimplemented date character "%s" in format "%s".', $dateChars[0], $this->pattern));
         }
 
         return '';

Globals/IntlGlobals.php

@@ -108,7 +108,7 @@ public static function getErrorName(int $code): string
     public static function setError(int $code, string $message = '')
     {
         if (!isset(self::$errorCodes[$code])) {
-            throw new \InvalidArgumentException(sprintf('No such error code: "%s"', $code));
+            throw new \InvalidArgumentException(sprintf('No such error code: "%s".', $code));
         }
 
         self::$errorMessage = $message ? sprintf('%s: %s', $message, self::$errorCodes[$code]) : self::$errorCodes[$code];

NumberFormatter/NumberFormatter.php

@@ -360,7 +360,7 @@ public function format($value, int $type = self::TYPE_DEFAULT)
         }
 
         if (self::CURRENCY === $this->style) {
-            throw new NotImplementedException(sprintf('%s() method does not support the formatting of currencies (instance with CURRENCY style). %s', __METHOD__, NotImplementedException::INTL_INSTALL_MESSAGE));
+            throw new NotImplementedException(sprintf('%s() method does not support the formatting of currencies (instance with CURRENCY style). %s.', __METHOD__, NotImplementedException::INTL_INSTALL_MESSAGE));
         }
 
         // Only the default type is supported.