bug #39271 [HttpFoundation] Fix TypeError: Argument 1 passed to JsonResponse::setJson() must be of the type string, object given (sidz)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[HttpFoundation] Fix TypeError: Argument 1 passed to JsonResponse::setJson() must be of the type string, object given

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

This PR fixes the type error when user set `null` as data in the `new JsonResponse(null, 200, [], true)` and true in the fourth argument to mark that value is json.
```
TypeError: Argument 1 passed to Symfony\Component\HttpFoundation\JsonResponse::setJson() must be of the type string, object given, called in /home/projects/symfony/src/Symfony/Component/HttpFoundation/JsonResponse.php on line 52
```

Commits
-------

7fcba9611d [HttpFoundation] Fix TypeError: Argument 1 passed to JsonResponse::setJson() must be of the type string, object given

Author: derrabus

JsonResponse.php

@@ -43,6 +43,10 @@ public function __construct($data = null, int $status = 200, array $headers = []
     {
         parent::__construct('', $status, $headers);
 
+        if ($json && !\is_string($data) && !is_numeric($data) && !\is_callable([$data, '__toString'])) {
+            throw new \TypeError(sprintf('"%s": If $json is set to true, argument $data must be a string or object implementing __toString(), "%s" given.', __METHOD__, get_debug_type($data)));
+        }
+
         if (null === $data) {
             $data = new \ArrayObject();
         }
@@ -77,13 +81,13 @@ public static function create($data = null, $status = 200, $headers = [])
      *     return JsonResponse::fromJsonString('{"key": "value"}')
      *         ->setSharedMaxAge(300);
      *
-     * @param string|null $data    The JSON response string
-     * @param int         $status  The response status code
-     * @param array       $headers An array of response headers
+     * @param string $data    The JSON response string
+     * @param int    $status  The response status code
+     * @param array  $headers An array of response headers
      *
      * @return static
      */
-    public static function fromJsonString($data = null, $status = 200, $headers = [])
+    public static function fromJsonString($data, $status = 200, $headers = [])
     {
         return new static($data, $status, $headers, true);
     }

Tests/JsonResponseTest.php

@@ -240,6 +240,44 @@ public function testSetComplexCallback()
 
         $this->assertEquals('/**/ಠ_ಠ["foo"].bar[0]({"foo":"bar"});', $response->getContent());
     }
+
+    public function testConstructorWithNullAsDataThrowsAnUnexpectedValueException()
+    {
+        $this->expectException(\TypeError::class);
+        $this->expectExceptionMessage('If $json is set to true, argument $data must be a string or object implementing __toString(), "null" given.');
+
+        new JsonResponse(null, 200, [], true);
+    }
+
+    public function testfromJsonStringConstructorWithNullAsDataThrowsAnUnexpectedValueException()
+    {
+        $this->expectException(\TypeError::class);
+        $this->expectExceptionMessage('If $json is set to true, argument $data must be a string or object implementing __toString(), "null" given.');
+
+        JsonResponse::fromJsonString(null);
+    }
+
+    public function testConstructorWithObjectWithToStringMethod()
+    {
+        $class = new class() {
+            public function __toString()
+            {
+                return '{}';
+            }
+        };
+
+        $response = new JsonResponse($class, 200, [], true);
+
+        $this->assertSame('{}', $response->getContent());
+    }
+
+    public function testConstructorWithObjectWithoutToStringMethodThrowsAnException()
+    {
+        $this->expectException(\TypeError::class);
+        $this->expectExceptionMessage('If $json is set to true, argument $data must be a string or object implementing __toString(), "stdClass" given.');
+
+        new JsonResponse(new \stdClass(), 200, [], true);
+    }
 }
 
 if (interface_exists('JsonSerializable', false)) {

composer.json

@@ -18,7 +18,8 @@
     "require": {
         "php": ">=7.1.3",
         "symfony/mime": "^4.3|^5.0",
-        "symfony/polyfill-mbstring": "~1.1"
+        "symfony/polyfill-mbstring": "~1.1",
+        "symfony/polyfill-php80": "^1.15"
     },
     "require-dev": {
         "predis/predis": "~1.0",