Merge branch '7.4' into 8.0

* 7.4: (28 commits)
  [Messenger] Allow Pheanstalk v8
  [TypeInfo] Fix resolving constructor type with templates
  fix compatibility with RelayCluster 0.12
  fix type alias with template resolving
  fix compatibility with RelayCluster 0.11 and 0.12
  [DependencyInjection] Register a custom autoloader to generate `*Config` classes when they don't exist yet
  [Security] Add security:oidc-token:generate command
  [PropertyInfo][TypeInfo] Fix resolving constructor type with templates
  [WebProfilerBundle] ”finish” errored requests
  Add support for union types on AsEventListener
  [Console] Update CHANGELOG to reflect attribute name changes for interactive invokable commands
  bump ext-redis to 6.2 and ext-relay to 0.12 minimum
  [TypeInfo] Fix type alias with template resolving
  [Console] Add support for interactive invokable commands with `#[Interact]` and `#[Ask]` attributes
  bump ext-relay to 0.12+
  fix merge
  [Config] Generate the array-shape of the current node instead of the whole root node in Config classes
  [HttpFoundation] Deprecate Request::get() in favor of using properties ->attributes, query or request directly
  fix Relay Cluster 0.12 compatibility
  [TypeInfo] ArrayShape can resolve key type as callable instead of string
  ...

Author: nicolas-grekas

CHANGELOG.md

@@ -14,10 +14,11 @@ CHANGELOG
 7.4
 ---
 
- * Deprecate using `Request::sendHeaders()` after headers have already been sent; use a `StreamedResponse` instead
  * Add `#[WithHttpStatus]` to define status codes: 404 for `SignedUriException` and 403 for `ExpiredSignedUriException`
  * Add support for the `QUERY` HTTP method
  * Add support for structured MIME suffix
+ * Deprecate using `Request::sendHeaders()` after headers have already been sent; use a `StreamedResponse` instead
+ * Deprecate method `Request::get()`, use properties `->attributes`, `query` or `request` directly instead
 
 7.3
 ---

Request.php

@@ -468,8 +468,8 @@ public function duplicate(?array $query = null, ?array $request = null, ?array $
         $dup->method = null;
         $dup->format = null;
 
-        if (!$dup->get('_format') && $this->get('_format')) {
-            $dup->attributes->set('_format', $this->get('_format'));
+        if (!$dup->attributes->has('_format') && $this->attributes->has('_format')) {
+            $dup->attributes->set('_format', $this->attributes->get('_format'));
         }
 
         if (!$dup->getRequestFormat(null)) {
@@ -679,10 +679,12 @@ public static function getHttpMethodParameterOverride(): bool
      *
      * Order of precedence: PATH (routing placeholders or custom attributes), GET, POST
      *
-     * @internal use explicit input sources instead
+     * @deprecated since Symfony 7.4, use properties `->attributes`, `query` or `request` directly instead
      */
     public function get(string $key, mixed $default = null): mixed
     {
+        trigger_deprecation('symfony/http-foundation', '7.4', 'Request::get() is deprecated, use properties ->attributes, query or request directly instead.');
+
         if ($this !== $result = $this->attributes->get($key, $this)) {
             return $result;
         }
@@ -1109,10 +1111,8 @@ public function getHost(): string
     {
         if ($this->isFromTrustedProxy() && $host = $this->getTrustedValues(self::HEADER_X_FORWARDED_HOST)) {
             $host = $host[0];
-        } elseif (!$host = $this->headers->get('HOST')) {
-            if (!$host = $this->server->get('SERVER_NAME')) {
-                $host = $this->server->get('SERVER_ADDR', '');
-            }
+        } else {
+            $host = $this->headers->get('HOST') ?: $this->server->get('SERVER_NAME') ?: $this->server->get('SERVER_ADDR', '');
         }
 
         // trim and remove port number from host

Tests/RequestTest.php

@@ -12,6 +12,8 @@
 namespace Symfony\Component\HttpFoundation\Tests;
 
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\Group;
+use PHPUnit\Framework\Attributes\IgnoreDeprecations;
 use PHPUnit\Framework\Attributes\RequiresPhpExtension;
 use PHPUnit\Framework\Attributes\TestWith;
 use PHPUnit\Framework\TestCase;
@@ -1508,6 +1510,8 @@ public function testGetPathInfo()
         $this->assertEquals('/', $request->getPathInfo());
     }
 
+    #[IgnoreDeprecations]
+    #[Group('legacy')]
     public function testGetParameterPrecedence()
     {
         $request = new Request();