[HttpFoundation] Fix RequestTest insulation

Author: nicolas-grekas

AcceptHeader.php

@@ -46,18 +46,15 @@ public function __construct(array $items)
      */
     public static function fromString(?string $headerValue): self
     {
-        $parts = HeaderUtils::split($headerValue ?? '', ',;=');
+        $items = [];
+        foreach (HeaderUtils::split($headerValue ?? '', ',;=') as $i => $parts) {
+            $part = array_shift($parts);
+            $item = new AcceptHeaderItem($part[0], HeaderUtils::combine($parts));
 
-        return new self(array_map(function ($subParts) {
-            static $index = 0;
-            $part = array_shift($subParts);
-            $attributes = HeaderUtils::combine($subParts);
-
-            $item = new AcceptHeaderItem($part[0], $attributes);
-            $item->setIndex($index++);
+            $items[] = $item->setIndex($i);
+        }
 
-            return $item;
-        }, $parts));
+        return new self($items);
     }
 
     /**
@@ -95,10 +92,11 @@ public function get(string $value): ?AcceptHeaderItem
             return null;
         }
 
-        usort($candidates, fn ($a, $b) =>
-            $this->getSpecificity($b, $queryItem) <=> $this->getSpecificity($a, $queryItem) // Descending specificity
-            ?: $b->getQuality() <=> $a->getQuality() // Descending quality
-            ?: $a->getIndex() <=> $b->getIndex() // Ascending index (stability)
+        usort(
+            $candidates,
+            fn ($a, $b) => $this->getSpecificity($b, $queryItem) <=> $this->getSpecificity($a, $queryItem) // Descending specificity
+                ?: $b->getQuality() <=> $a->getQuality() // Descending quality
+                ?: $a->getIndex() <=> $b->getIndex() // Ascending index (stability)
         );
 
         return reset($candidates);

Tests/Fixtures/response-functional/invalid_cookie_name.php

@@ -6,6 +6,6 @@
 
 try {
     $r->headers->setCookie(new Cookie('Hello + world', 'hodor', 0, null, null, null, false, true));
-} catch (\InvalidArgumentException $e) {
+} catch (InvalidArgumentException $e) {
     echo $e->getMessage();
 }

Tests/RequestTest.php

@@ -31,6 +31,8 @@ protected function tearDown(): void
     {
         Request::setTrustedProxies([], -1);
         Request::setTrustedHosts([]);
+        Request::setFactory(null);
+        \Closure::bind(static fn () => self::$formats = null, null, Request::class)();
     }
 
     public function testInitialize()