Backport type fixes

Author: nicolas-grekas

File/UploadedFile.php

@@ -254,7 +254,7 @@ public static function getMaxFilesize()
      *
      * @return int|float Returns float if size > PHP_INT_MAX
      */
-    private static function parseFilesize($size)
+    private static function parseFilesize(string $size)
     {
         if ('' === $size) {
             return 0;

FileBag.php

@@ -75,22 +75,20 @@ protected function convertFileInformation($file)
             return $file;
         }
 
-        if (\is_array($file)) {
-            $file = $this->fixPhpFilesArray($file);
-            $keys = array_keys($file);
-            sort($keys);
-
-            if (self::FILE_KEYS == $keys) {
-                if (\UPLOAD_ERR_NO_FILE == $file['error']) {
-                    $file = null;
-                } else {
-                    $file = new UploadedFile($file['tmp_name'], $file['name'], $file['type'], $file['error'], false);
-                }
+        $file = $this->fixPhpFilesArray($file);
+        $keys = array_keys($file);
+        sort($keys);
+
+        if (self::FILE_KEYS == $keys) {
+            if (\UPLOAD_ERR_NO_FILE == $file['error']) {
+                $file = null;
             } else {
-                $file = array_map([$this, 'convertFileInformation'], $file);
-                if (array_keys($keys) === $keys) {
-                    $file = array_filter($file);
-                }
+                $file = new UploadedFile($file['tmp_name'], $file['name'], $file['type'], $file['error'], false);
+            }
+        } else {
+            $file = array_map(function ($v) { return $v instanceof UploadedFile || \is_array($v) ? $this->convertFileInformation($v) : $v; }, $file);
+            if (array_keys($keys) === $keys) {
+                $file = array_filter($file);
             }
         }
 

HeaderBag.php

@@ -133,9 +133,9 @@ public function get($key, $default = null)
     /**
      * Sets a header by name.
      *
-     * @param string          $key     The key
-     * @param string|string[] $values  The value or an array of values
-     * @param bool            $replace Whether to replace the actual value or not (true by default)
+     * @param string               $key     The key
+     * @param string|string[]|null $values  The value or an array of values
+     * @param bool                 $replace Whether to replace the actual value or not (true by default)
      */
     public function set($key, $values, $replace = true)
     {
@@ -228,8 +228,8 @@ public function getDate($key, \DateTime $default = null)
     /**
      * Adds a custom Cache-Control directive.
      *
-     * @param string $key   The Cache-Control directive name
-     * @param mixed  $value The Cache-Control directive value
+     * @param string      $key   The Cache-Control directive name
+     * @param bool|string $value The Cache-Control directive value
      */
     public function addCacheControlDirective($key, $value = true)
     {
@@ -255,11 +255,11 @@ public function hasCacheControlDirective($key)
      *
      * @param string $key The directive name
      *
-     * @return mixed The directive value if defined, null otherwise
+     * @return bool|string|null The directive value if defined, null otherwise
      */
     public function getCacheControlDirective($key)
     {
-        return \array_key_exists($key, $this->cacheControl) ? $this->cacheControl[$key] : null;
+        return $this->cacheControl[$key] ?? null;
     }
 
     /**

Tests/JsonResponseTest.php

@@ -257,7 +257,7 @@ public function testfromJsonStringConstructorWithNullAsDataThrowsAnUnexpectedVal
     public function testConstructorWithObjectWithToStringMethod()
     {
         $class = new class() {
-            public function __toString()
+            public function __toString(): string
             {
                 return '{}';
             }

Tests/Session/Storage/Handler/AbstractRedisSessionHandlerTestCase.php

@@ -122,7 +122,7 @@ public function testUpdateTimestamp()
         $lowTtl = 10;
 
         $this->redisClient->setex(self::PREFIX.'id', $lowTtl, 'foo');
-        $this->storage->updateTimestamp('id', []);
+        $this->storage->updateTimestamp('id', 'data');
 
         $this->assertGreaterThan($lowTtl, $this->redisClient->ttl(self::PREFIX.'id'));
     }