bug #58862 [Notifier] Fix GoIpTransport (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 40e6615d2dc2 · 2024-11-13T19:55:16.000+01:00
This PR was merged into the 6.4 branch.

Discussion
----------

[Notifier] Fix GoIpTransport

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

And some other tests

Commits
-------

5afb93c518f [Notifier] Fix GoIpTransport
diff --git a/Tests/RequestTest.php b/Tests/RequestTest.php
@@ -2668,16 +2668,6 @@ public function testReservedFlags()
             $this->assertNotSame(0b10000000, $value, sprintf('The constant "%s" should not use the reserved value "0b10000000".', $constant));
         }
     }
-
-    /**
-     * @group legacy
-     */
-    public function testInvalidUriCreationDeprecated()
-    {
-        $this->expectDeprecation('Since symfony/http-foundation 6.3: Calling "Symfony\Component\HttpFoundation\Request::create()" with an invalid URI is deprecated.');
-        $request = Request::create('/invalid-path:123');
-        $this->assertEquals('http://localhost/invalid-path:123', $request->getUri());
-    }
 }
 
 class RequestContentProxy extends Request

Original file line number	Diff line number	Diff line change
`@@ -2668,16 +2668,6 @@ public function testReservedFlags()`
`2668`	`2668`	`$this->assertNotSame(0b10000000, $value, sprintf('The constant "%s" should not use the reserved value "0b10000000".', $constant));`
`2669`	`2669`	`}`
`2670`	`2670`	`}`
`2671`		`-`
`2672`		`- /**`
`2673`		`- * @group legacy`
`2674`		`- */`
`2675`		`- public function testInvalidUriCreationDeprecated()`
`2676`		`- {`
`2677`		`- $this->expectDeprecation('Since symfony/http-foundation 6.3: Calling "Symfony\Component\HttpFoundation\Request::create()" with an invalid URI is deprecated.');`
`2678`		`- $request = Request::create('/invalid-path:123');`
`2679`		`- $this->assertEquals('http://localhost/invalid-path:123', $request->getUri());`
`2680`		`- }`
`2681`	`2671`	`}`
`2682`	`2672`
`2683`	`2673`	`class RequestContentProxy extends Request`