Skip to content

Commit fa23b8d

Browse files
committed
minor #62164 Clean up legacy groups in tests (xabbuh)
This PR was merged into the 7.4 branch. Discussion ---------- Clean up legacy groups in tests | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT In the past, we needed the legacy group with PHPUnit < 10 to indicate that a test was expected to trigger deprecations. With our update to PHPUnit 12 this is no longer necessary. We now use the group only to skip these tests when running high deps tests with different major versions. The tests from which the legacy group is dropped do not handle deprecated Symfony features but deal with features that users can use to trigger deprecations leveraging our components. They don't have to be skipped in cross-version test runs. Commits ------- 7f0acb45e46 clean up legacy groups in tests
2 parents 29d7a4d + 93c6109 commit fa23b8d

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

Tests/Console/Descriptor/AbstractDescriptorTestCase.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
namespace Symfony\Bundle\FrameworkBundle\Tests\Console\Descriptor;
1313

1414
use PHPUnit\Framework\Attributes\DataProvider;
15-
use PHPUnit\Framework\Attributes\Group;
1615
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
1716
use PHPUnit\Framework\TestCase;
1817
use Symfony\Bundle\FrameworkBundle\Tests\Fixtures\FooUnitEnum;
@@ -189,7 +188,6 @@ public static function getDescribeContainerDefinitionWhichIsAnAliasTestData(): a
189188
* The #[IgnoreDeprecation] attribute must be kept as deprecations will always be raised.
190189
*/
191190
#[IgnoreDeprecations]
192-
#[Group('legacy')]
193191
#[DataProvider('getDescribeContainerParameterTestData')]
194192
public function testDescribeContainerParameter($parameter, $expectedDescription, array $options, $file)
195193
{
@@ -236,7 +234,6 @@ public static function getDescribeCallableTestData(): array
236234
}
237235

238236
#[IgnoreDeprecations]
239-
#[Group('legacy')]
240237
#[DataProvider('getDescribeDeprecatedCallableTestData')]
241238
public function testDescribeDeprecatedCallable($callable, $expectedDescription, $file)
242239
{

0 commit comments

Comments
 (0)