[FrameworkBundle] Add types to private properties

Author: derrabus

CacheWarmer/AbstractPhpFileCacheWarmer.php

@@ -19,7 +19,7 @@
 
 abstract class AbstractPhpFileCacheWarmer implements CacheWarmerInterface
 {
-    private $phpArrayFile;
+    private string $phpArrayFile;
 
     /**
      * @param string $phpArrayFile The PHP file where metadata are cached

CacheWarmer/AnnotationsCacheWarmer.php

@@ -25,9 +25,9 @@
  */
 class AnnotationsCacheWarmer extends AbstractPhpFileCacheWarmer
 {
-    private $annotationReader;
-    private $excludeRegexp;
-    private $debug;
+    private Reader $annotationReader;
+    private ?string $excludeRegexp;
+    private bool $debug;
 
     /**
      * @param string $phpArrayFile The PHP file where annotations are cached

CacheWarmer/CachePoolClearerCacheWarmer.php

@@ -25,9 +25,12 @@
  */
 final class CachePoolClearerCacheWarmer implements CacheWarmerInterface
 {
-    private $poolClearer;
-    private $pools;
+    private Psr6CacheClearer $poolClearer;
+    private array $pools;
 
+    /**
+     * @param string[] $pools
+     */
     public function __construct(Psr6CacheClearer $poolClearer, array $pools = [])
     {
         $this->poolClearer = $poolClearer;

CacheWarmer/ConfigBuilderCacheWarmer.php

@@ -28,8 +28,8 @@
  */
 class ConfigBuilderCacheWarmer implements CacheWarmerInterface
 {
-    private $kernel;
-    private $logger;
+    private KernelInterface $kernel;
+    private ?LoggerInterface $logger;
 
     public function __construct(KernelInterface $kernel, LoggerInterface $logger = null)
     {

CacheWarmer/RouterCacheWarmer.php

@@ -26,7 +26,7 @@
  */
 class RouterCacheWarmer implements CacheWarmerInterface, ServiceSubscriberInterface
 {
-    private $container;
+    private ContainerInterface $container;
 
     public function __construct(ContainerInterface $container)
     {

CacheWarmer/SerializerCacheWarmer.php

@@ -27,7 +27,7 @@
  */
 class SerializerCacheWarmer extends AbstractPhpFileCacheWarmer
 {
-    private $loaders;
+    private array $loaders;
 
     /**
      * @param LoaderInterface[] $loaders      The serializer metadata loaders

CacheWarmer/TranslationsCacheWarmer.php

@@ -24,8 +24,8 @@
  */
 class TranslationsCacheWarmer implements CacheWarmerInterface, ServiceSubscriberInterface
 {
-    private $container;
-    private $translator;
+    private ContainerInterface $container;
+    private TranslatorInterface $translator;
 
     public function __construct(ContainerInterface $container)
     {
@@ -40,9 +40,7 @@ public function __construct(ContainerInterface $container)
      */
     public function warmUp(string $cacheDir): array
     {
-        if (null === $this->translator) {
-            $this->translator = $this->container->get('translator');
-        }
+        $this->translator ??= $this->container->get('translator');
 
         if ($this->translator instanceof WarmableInterface) {
             return (array) $this->translator->warmUp($cacheDir);

CacheWarmer/ValidatorCacheWarmer.php

@@ -28,7 +28,7 @@
  */
 class ValidatorCacheWarmer extends AbstractPhpFileCacheWarmer
 {
-    private $validatorBuilder;
+    private ValidatorBuilder $validatorBuilder;
 
     /**
      * @param string $phpArrayFile The PHP file where metadata are cached

Command/AssetsInstallCommand.php

@@ -41,8 +41,8 @@ class AssetsInstallCommand extends Command
     public const METHOD_ABSOLUTE_SYMLINK = 'absolute symlink';
     public const METHOD_RELATIVE_SYMLINK = 'relative symlink';
 
-    private $filesystem;
-    private $projectDir;
+    private Filesystem $filesystem;
+    private string $projectDir;
 
     public function __construct(Filesystem $filesystem, string $projectDir)
     {

Command/CacheClearCommand.php

@@ -37,8 +37,8 @@
 #[AsCommand(name: 'cache:clear', description: 'Clear the cache')]
 class CacheClearCommand extends Command
 {
-    private $cacheClearer;
-    private $filesystem;
+    private CacheClearerInterface $cacheClearer;
+    private Filesystem $filesystem;
 
     public function __construct(CacheClearerInterface $cacheClearer, Filesystem $filesystem = null)
     {