|
11 | 11 |
|
12 | 12 | namespace Symfony\Bundle\FrameworkBundle\Tests\Kernel; |
13 | 13 |
|
| 14 | +use PHPUnit\Framework\Attributes\BackupGlobals; |
14 | 15 | use PHPUnit\Framework\TestCase; |
15 | 16 | use Psr\Log\NullLogger; |
16 | 17 | use Symfony\Bundle\FrameworkBundle\Console\Application; |
@@ -46,47 +47,33 @@ protected function tearDown(): void |
46 | 47 | } |
47 | 48 | } |
48 | 49 |
|
| 50 | + #[BackupGlobals(true)] |
49 | 51 | public function testGetShareDirDisabledByEnv() |
50 | 52 | { |
51 | | - $previous = $_SERVER['APP_SHARE_DIR'] ?? null; |
52 | 53 | $_SERVER['APP_SHARE_DIR'] = 'false'; |
53 | 54 |
|
54 | | - try { |
55 | | - $kernel = $this->kernel = new ConcreteMicroKernel('test', false); |
| 55 | + $kernel = $this->kernel = new ConcreteMicroKernel('test', false); |
56 | 56 |
|
57 | | - $this->assertNull($kernel->getShareDir()); |
| 57 | + $this->assertNull($kernel->getShareDir()); |
58 | 58 |
|
59 | | - $parameters = $kernel->getKernelParameters(); |
60 | | - $this->assertArrayNotHasKey('kernel.share_dir', $parameters); |
61 | | - } finally { |
62 | | - if (null === $previous) { |
63 | | - unset($_SERVER['APP_SHARE_DIR']); |
64 | | - } else { |
65 | | - $_SERVER['APP_SHARE_DIR'] = $previous; |
66 | | - } |
67 | | - } |
| 59 | + $parameters = $kernel->getKernelParameters(); |
| 60 | + $this->assertArrayNotHasKey('kernel.share_dir', $parameters); |
68 | 61 | } |
69 | 62 |
|
| 63 | + #[BackupGlobals(true)] |
70 | 64 | public function testGetShareDirCustomPathFromEnv() |
71 | 65 | { |
72 | | - $previous = $_SERVER['APP_SHARE_DIR'] ?? null; |
73 | 66 | $_SERVER['APP_SHARE_DIR'] = sys_get_temp_dir(); |
74 | 67 |
|
75 | | - try { |
76 | | - $kernel = $this->kernel = new ConcreteMicroKernel('test', false); |
| 68 | + $kernel = $this->kernel = new ConcreteMicroKernel('test', false); |
77 | 69 |
|
78 | | - $expected = rtrim(sys_get_temp_dir(), '/').'/test'; |
79 | | - $this->assertSame($expected, $kernel->getShareDir()); |
| 70 | + $expected = rtrim(sys_get_temp_dir(), '/').'/test'; |
| 71 | + $this->assertSame($expected, $kernel->getShareDir()); |
80 | 72 |
|
81 | | - $parameters = $kernel->getKernelParameters(); |
82 | | - $this->assertSame($expected, $parameters['kernel.share_dir'] ?? null); |
83 | | - } finally { |
84 | | - if (null === $previous) { |
85 | | - unset($_SERVER['APP_SHARE_DIR']); |
86 | | - } else { |
87 | | - $_SERVER['APP_SHARE_DIR'] = $previous; |
88 | | - } |
89 | | - } |
| 73 | + $parameters = $kernel->getKernelParameters(); |
| 74 | + $this->assertArrayHasKey('kernel.share_dir', $parameters); |
| 75 | + $this->assertNotNull($parameters['kernel.share_dir']); |
| 76 | + $this->assertSame(realpath($expected), realpath($parameters['kernel.share_dir'])); |
90 | 77 | } |
91 | 78 |
|
92 | 79 | public function test() |
|
0 commit comments