Skip to content

Commit 5232aad

Browse files
committed
Merge branch '7.4' into 8.0
* 7.4: fix test on Windows simplify test Bump Symfony version to 7.4.0 Update VERSION for 7.4.0-BETA2 Update CHANGELOG for 7.4.0-BETA2
2 parents 8707618 + 7127cd6 commit 5232aad

File tree

1 file changed

+14
-27
lines changed

1 file changed

+14
-27
lines changed

Tests/Kernel/MicroKernelTraitTest.php

Lines changed: 14 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Symfony\Bundle\FrameworkBundle\Tests\Kernel;
1313

14+
use PHPUnit\Framework\Attributes\BackupGlobals;
1415
use PHPUnit\Framework\TestCase;
1516
use Psr\Log\NullLogger;
1617
use Symfony\Bundle\FrameworkBundle\Console\Application;
@@ -46,47 +47,33 @@ protected function tearDown(): void
4647
}
4748
}
4849

50+
#[BackupGlobals(true)]
4951
public function testGetShareDirDisabledByEnv()
5052
{
51-
$previous = $_SERVER['APP_SHARE_DIR'] ?? null;
5253
$_SERVER['APP_SHARE_DIR'] = 'false';
5354

54-
try {
55-
$kernel = $this->kernel = new ConcreteMicroKernel('test', false);
55+
$kernel = $this->kernel = new ConcreteMicroKernel('test', false);
5656

57-
$this->assertNull($kernel->getShareDir());
57+
$this->assertNull($kernel->getShareDir());
5858

59-
$parameters = $kernel->getKernelParameters();
60-
$this->assertArrayNotHasKey('kernel.share_dir', $parameters);
61-
} finally {
62-
if (null === $previous) {
63-
unset($_SERVER['APP_SHARE_DIR']);
64-
} else {
65-
$_SERVER['APP_SHARE_DIR'] = $previous;
66-
}
67-
}
59+
$parameters = $kernel->getKernelParameters();
60+
$this->assertArrayNotHasKey('kernel.share_dir', $parameters);
6861
}
6962

63+
#[BackupGlobals(true)]
7064
public function testGetShareDirCustomPathFromEnv()
7165
{
72-
$previous = $_SERVER['APP_SHARE_DIR'] ?? null;
7366
$_SERVER['APP_SHARE_DIR'] = sys_get_temp_dir();
7467

75-
try {
76-
$kernel = $this->kernel = new ConcreteMicroKernel('test', false);
68+
$kernel = $this->kernel = new ConcreteMicroKernel('test', false);
7769

78-
$expected = rtrim(sys_get_temp_dir(), '/').'/test';
79-
$this->assertSame($expected, $kernel->getShareDir());
70+
$expected = rtrim(sys_get_temp_dir(), '/').'/test';
71+
$this->assertSame($expected, $kernel->getShareDir());
8072

81-
$parameters = $kernel->getKernelParameters();
82-
$this->assertSame($expected, $parameters['kernel.share_dir'] ?? null);
83-
} finally {
84-
if (null === $previous) {
85-
unset($_SERVER['APP_SHARE_DIR']);
86-
} else {
87-
$_SERVER['APP_SHARE_DIR'] = $previous;
88-
}
89-
}
73+
$parameters = $kernel->getKernelParameters();
74+
$this->assertArrayHasKey('kernel.share_dir', $parameters);
75+
$this->assertNotNull($parameters['kernel.share_dir']);
76+
$this->assertSame(realpath($expected), realpath($parameters['kernel.share_dir']));
9077
}
9178

9279
public function test()

0 commit comments

Comments
 (0)