[FrameworkBundle] Deprecate creating public workflow services

Author: fancyweb

CHANGELOG.md

@@ -19,6 +19,7 @@ CHANGELOG
  * Add `KernelTestCase::getContainer()` as the best way to get a container in tests
  * Rename the container parameter `profiler_listener.only_master_requests` to `profiler_listener.only_main_requests`
  * Add service `fragment.uri_generator` to generate the URI of a fragment
+ * Deprecate registering workflow services as public
 
 5.2.0
 -----

DependencyInjection/FrameworkExtension.php

@@ -863,6 +863,10 @@ private function registerWorkflowConfiguration(array $config, ContainerBuilder $
             $workflowDefinition->replaceArgument(1, $markingStoreDefinition ?? null);
             $workflowDefinition->replaceArgument(3, $name);
             $workflowDefinition->replaceArgument(4, $workflow['events_to_dispatch']);
+            $workflowDefinition->addTag('container.private', [
+                'package' => 'symfony/framework-bundle',
+                'version' => '5.3',
+            ]);
 
             // Store to container
             $container->setDefinition($workflowId, $workflowDefinition);

Resources/config/workflow.php

@@ -29,6 +29,7 @@
             ])
             ->abstract()
             ->public()
+            ->tag('container.private', ['package' => 'symfony/framework-bundle', 'version' => '5.3'])
         ->set('state_machine.abstract', StateMachine::class)
             ->args([
                 abstract_arg('workflow definition'),
@@ -39,6 +40,7 @@
             ])
             ->abstract()
             ->public()
+            ->tag('container.private', ['package' => 'symfony/framework-bundle', 'version' => '5.3'])
         ->set('workflow.marking_store.method', MethodMarkingStore::class)
             ->abstract()
         ->set('workflow.registry', Registry::class)