bug #46442 [FrameworkBundle] Revert "bug #46125 Always add CacheCollectorPass (fancyweb)" (chalasr)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Revert "bug #46125  Always add CacheCollectorPass (fancyweb)"

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #46416
| License       | MIT
| Doc PR        | -

This reverts commit 8b6f56e3805ab3231ffebfbe9648643a364af725, reversing
changes made to fd1c94ba5676b9943e02a457166651a072b0018f.

This change appears to be breaking for some, let's rediscuss it on 6.2.

Commits
-------

36d6516d81 Revert "bug #46125 [FrameworkBundle] Always add CacheCollectorPass (fancyweb)"

Author: fabpot

FrameworkBundle.php

@@ -157,12 +157,12 @@ public function build(ContainerBuilder $container)
         $container->addCompilerPass(new RegisterReverseContainerPass(true));
         $container->addCompilerPass(new RegisterReverseContainerPass(false), PassConfig::TYPE_AFTER_REMOVING);
         $container->addCompilerPass(new SessionPass());
-        $container->addCompilerPass(new CacheCollectorPass(), PassConfig::TYPE_BEFORE_REMOVING);
 
         if ($container->getParameter('kernel.debug')) {
             $container->addCompilerPass(new AddDebugLogProcessorPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 2);
             $container->addCompilerPass(new UnusedTagsPass(), PassConfig::TYPE_AFTER_REMOVING);
             $container->addCompilerPass(new ContainerBuilderDebugDumpPass(), PassConfig::TYPE_BEFORE_REMOVING, -255);
+            $container->addCompilerPass(new CacheCollectorPass(), PassConfig::TYPE_BEFORE_REMOVING);
         }
     }