Merge branch '5.1' into 5.x

Author: derrabus

CHANGELOG.md

@@ -18,7 +18,7 @@ CHANGELOG
 
 5.1.0
 -----
-
+ * Removed `--no-backup` option from `translation:update` command (broken since `5.0.0`)
  * Added link to source for controllers registered as named services
  * Added link to source on controller on `router:match`/`debug:router` (when `framework.ide` is configured)
  * Added the `framework.router.default_uri` configuration option to configure the default `RequestContext`

Command/TranslationUpdateCommand.php

@@ -79,7 +79,6 @@ protected function configure()
                 new InputOption('output-format', null, InputOption::VALUE_OPTIONAL, 'Override the default output format', 'xlf'),
                 new InputOption('dump-messages', null, InputOption::VALUE_NONE, 'Should the messages be dumped in the console'),
                 new InputOption('force', null, InputOption::VALUE_NONE, 'Should the update be done'),
-                new InputOption('no-backup', null, InputOption::VALUE_NONE, 'Should backup be disabled'),
                 new InputOption('clean', null, InputOption::VALUE_NONE, 'Should clean not found messages'),
                 new InputOption('domain', null, InputOption::VALUE_OPTIONAL, 'Specify the domain to update'),
                 new InputOption('xliff-version', null, InputOption::VALUE_OPTIONAL, 'Override the default xliff version', '1.2'),
@@ -290,10 +289,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $resultMessage = sprintf('%d message%s successfully extracted', $extractedMessagesCount, $extractedMessagesCount > 1 ? 's were' : ' was');
         }
 
-        if (true === $input->getOption('no-backup')) {
-            $this->writer->disableBackup();
-        }
-
         // save the files
         if (true === $input->getOption('force')) {
             $io->comment('Writing files...');

DependencyInjection/FrameworkExtension.php

@@ -669,7 +669,7 @@ private function registerProfilerConfiguration(array $config, ContainerBuilder $
         $container->setParameter('profiler_listener.only_master_requests', $config['only_master_requests']);
 
         // Choose storage class based on the DSN
-        list($class) = explode(':', $config['dsn'], 2);
+        [$class] = explode(':', $config['dsn'], 2);
         if ('file' !== $class) {
             throw new \LogicException(sprintf('Driver "%s" is not supported for the profiler.', $class));
         }

Tests/Functional/Bundle/TestBundle/Controller/SessionController.php

@@ -71,7 +71,7 @@ public function showFlashAction(Request $request)
         $session = $request->getSession();
 
         if ($session->getFlashBag()->has('notice')) {
-            list($output) = $session->getFlashBag()->get('notice');
+            [$output] = $session->getFlashBag()->get('notice');
         } else {
             $output = 'No flash was set.';
         }

Translation/Translator.php

@@ -155,7 +155,7 @@ protected function initialize()
             $this->addResourceFiles();
         }
         foreach ($this->resources as $key => $params) {
-            list($format, $resource, $locale, $domain) = $params;
+            [$format, $resource, $locale, $domain] = $params;
             parent::addResource($format, $resource, $locale, $domain);
         }
         $this->resources = [];