[DependencyInjection][Routing] Remove support for the XML configuration format

Author: nicolas-grekas

CHANGELOG.md

@@ -10,6 +10,7 @@ CHANGELOG
  * Remove `ContainerBuilder::getAutoconfiguredAttributes()`, replaced by `ContainerBuilder::getAttributeAutoconfigurators()`
  * Remove `!tagged` tag, use `!tagged_iterator` instead
  * Add argument `$target` to `ContainerBuilder::registerAliasForArgument()`
+ * Remove support for the XML configuration format
 
 7.4
 ---

Extension/ExtensionTrait.php

@@ -22,7 +22,6 @@
 use Symfony\Component\DependencyInjection\Loader\GlobFileLoader;
 use Symfony\Component\DependencyInjection\Loader\IniFileLoader;
 use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
-use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
 
 /**
@@ -55,7 +54,6 @@ private function createContainerLoader(ContainerBuilder $container, string $env,
         $buildDir = $container->getParameter('kernel.build_dir');
         $locator = new FileLocator();
         $resolver = new LoaderResolver([
-            new XmlFileLoader($container, $locator, $env, $prepend),
             new YamlFileLoader($container, $locator, $env, $prepend),
             new IniFileLoader($container, $locator, $env),
             new PhpFileLoader($container, $locator, $env, new ConfigBuilderGenerator($buildDir), $prepend),

Loader/XmlFileLoader.php

@@ -18,7 +18,6 @@
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
 use Symfony\Bridge\PhpUnit\ClassExistsMock;
-use Symfony\Component\Config\FileLocator;
 use Symfony\Component\Config\Resource\ClassExistenceResource;
 use Symfony\Component\DependencyInjection\Argument\ServiceLocatorArgument;
 use Symfony\Component\DependencyInjection\Argument\TaggedIteratorArgument;
@@ -32,7 +31,6 @@
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\DependencyInjection\Exception\AutowiringFailedException;
 use Symfony\Component\DependencyInjection\Exception\RuntimeException;
-use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\BarInterface;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\CaseSensitiveClass;
@@ -989,22 +987,6 @@ public function testExceptionWhenAliasDoesNotExist()
         }
     }
 
-    #[IgnoreDeprecations]
-    #[Group('legacy')]
-    public function testInlineServicesAreNotCandidates()
-    {
-        $this->expectUserDeprecationMessage('Since symfony/dependency-injection 7.4: XML configuration format is deprecated, use YAML or PHP instead.');
-
-        $container = new ContainerBuilder();
-        $loader = new XmlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Fixtures/xml')));
-        $loader->load('services_inline_not_candidate.xml');
-
-        $pass = new AutowirePass();
-        $pass->process($container);
-
-        $this->assertSame([], $container->getDefinition('autowired')->getArguments());
-    }
-
     public function testAutowireDecorator()
     {
         $container = new ContainerBuilder();

Loader/schema/dic/services/services-1.0.xsd

@@ -12,14 +12,10 @@
 namespace Symfony\Component\DependencyInjection\Tests;
 
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\Attributes\Group;
-use PHPUnit\Framework\Attributes\IgnoreDeprecations;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\DependencyInjection\Dumper\XmlDumper;
 use Symfony\Component\DependencyInjection\Dumper\YamlDumper;
-use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
 
 class CrossCheckTest extends TestCase
@@ -34,49 +30,6 @@ public static function setUpBeforeClass(): void
         require_once self::$fixturesPath.'/includes/foo.php';
     }
 
-    #[IgnoreDeprecations]
-    #[Group('legacy')]
-    #[DataProvider('crossCheckXmlLoadersDumpers')]
-    public function testXmlCrossCheck($fixture)
-    {
-        $this->expectUserDeprecationMessage('Since symfony/dependency-injection 7.4: XML configuration format is deprecated, use YAML or PHP instead.');
-
-        $tmp = tempnam(sys_get_temp_dir(), 'sf');
-
-        copy(self::$fixturesPath.'/xml/'.$fixture, $tmp);
-
-        $container1 = new ContainerBuilder();
-        $loader1 = new XmlFileLoader($container1, new FileLocator());
-        $loader1->load($tmp);
-
-        $dumper = new XmlDumper($container1);
-        file_put_contents($tmp, $dumper->dump());
-
-        $container2 = new ContainerBuilder();
-        $loader2 = new XmlFileLoader($container2, new FileLocator());
-        $loader2->load($tmp);
-
-        unlink($tmp);
-
-        $this->assertEquals($container1->getAliases(), $container2->getAliases(), 'loading a dump from a previously loaded container returns the same container');
-        $this->assertEquals($container1->getDefinitions(), $container2->getDefinitions(), 'loading a dump from a previously loaded container returns the same container');
-        $this->assertEquals($container1->getParameterBag()->all(), $container2->getParameterBag()->all(), '->getParameterBag() returns the same value for both containers');
-        $this->assertEquals(serialize($container1), serialize($container2), 'loading a dump from a previously loaded container returns the same container');
-
-        $services1 = [];
-        foreach ($container1 as $id => $service) {
-            $services1[$id] = serialize($service);
-        }
-        $services2 = [];
-        foreach ($container2 as $id => $service) {
-            $services2[$id] = serialize($service);
-        }
-
-        unset($services1['service_container'], $services2['service_container']);
-
-        $this->assertEquals($services1, $services2, 'Iterator on the containers returns the same services');
-    }
-
     #[DataProvider('crossCheckYamlLoadersDumpers')]
     public function testYamlCrossCheck($fixture)
     {
@@ -116,17 +69,6 @@ public function testYamlCrossCheck($fixture)
         $this->assertEquals($services2, $services1, 'Iterator on the containers returns the same services');
     }
 
-    public static function crossCheckXmlLoadersDumpers()
-    {
-        return [
-            ['services1.xml'],
-            ['services2.xml'],
-            ['services6.xml'],
-            ['services8.xml'],
-            ['services9.xml'],
-        ];
-    }
-
     public static function crossCheckYamlLoadersDumpers()
     {
         return [

Tests/Compiler/AutowirePassTest.php

@@ -12,10 +12,7 @@
 namespace Symfony\Component\DependencyInjection\Tests\Dumper;
 
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\Attributes\Group;
-use PHPUnit\Framework\Attributes\IgnoreDeprecations;
 use PHPUnit\Framework\TestCase;
-use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\Argument\AbstractArgument;
 use Symfony\Component\DependencyInjection\Argument\ServiceClosureArgument;
 use Symfony\Component\DependencyInjection\Argument\ServiceLocatorArgument;
@@ -24,7 +21,6 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\DependencyInjection\Dumper\XmlDumper;
-use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\FooClassWithDefaultArrayAttribute;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\FooClassWithDefaultEnumAttribute;
@@ -191,22 +187,6 @@ public function testDumpAutowireData()
         $this->assertEquals(file_get_contents(self::$fixturesPath.'/xml/services24.xml'), $dumper->dump());
     }
 
-    #[IgnoreDeprecations]
-    #[Group('legacy')]
-    public function testDumpLoad()
-    {
-        $this->expectUserDeprecationMessage('Since symfony/dependency-injection 7.4: XML configuration format is deprecated, use YAML or PHP instead.');
-
-        $container = new ContainerBuilder();
-        $loader = new XmlFileLoader($container, new FileLocator(self::$fixturesPath.'/xml'));
-        $loader->load('services_dump_load.xml');
-
-        $this->assertEquals([new Reference('bar', ContainerInterface::IGNORE_ON_UNINITIALIZED_REFERENCE)], $container->getDefinition('foo')->getArguments());
-
-        $dumper = new XmlDumper($container);
-        $this->assertStringEqualsFile(self::$fixturesPath.'/xml/services_dump_load.xml', $dumper->dump());
-    }
-
     public function testTaggedArguments()
     {
         $taggedIterator = new TaggedIteratorArgument('foo_tag', 'barfoo', 'foobar', false, 'getPriority');