Merge pull request swiftlang#84537 from egorzhdan/egorzhdan/disable-deducing-this

[cxx-interop] Do not import C++23 deducing this

Author: egorzhdan

lib/ClangImporter/ImportName.cpp

@@ -1538,6 +1538,10 @@ ImportedName NameImporter::importNameImpl(const clang::NamedDecl *D,
   if (!swift3OrLaterName && isa<clang::CXXMethodDecl>(D)) {
     return ImportedName();
   }
+  // If this function uses C++23 deducing this, bail.
+  if (auto functionDecl = dyn_cast<clang::FunctionDecl>(D))
+    if (functionDecl->hasCXXExplicitFunctionObjectParameter())
+      return {};
 
   // Dig out the definition, if there is one.
   if (auto def = getDefinitionForClangTypeDecl(D)) {

test/Interop/Cxx/class/method/Inputs/deducing-this.h

@@ -0,0 +1,4 @@
+struct HasDeducingThis {
+  int value;
+  int deducingRef(this HasDeducingThis &self) { return self.value; }
+};

test/Interop/Cxx/class/method/Inputs/module.modulemap

@@ -1,3 +1,8 @@
+module DeducingThis {
+  header "deducing-this.h"
+  requires cplusplus23
+}
+
 module Methods {
   header "methods.h"
   requires cplusplus

test/Interop/Cxx/class/method/deducing-this-module-interface.swift

@@ -0,0 +1,6 @@
+// RUN: %target-swift-ide-test -print-module -module-to-print=DeducingThis -I %S/Inputs -source-filename=x -cxx-interoperability-mode=upcoming-swift -Xcc -std=c++23 | %FileCheck %s
+
+// This mostly ensures that we don't import deducing this method with an incorrect signature.
+
+// CHECK: struct HasDeducingThis {
+// CHECK-NOT:   deducingRef