fix(screentext): byebye setprop

Author: skuzzis

src/core/entrypoint.cpp

@@ -285,11 +285,8 @@ void SwiftlyS2::AllPluginsLoaded()
 
 std::string currentMap = "None";
 
-void EraseScheduledCEntKeyVals();
-
 void SwiftlyS2::OnLevelInit(char const* pMapName, char const* pMapEntities, char const* pOldLevel, char const* pLandmarkName, bool loadGame, bool background)
 {
-    EraseScheduledCEntKeyVals();
     currentMap = pMapName;
     g_pluginManager.ExecuteEvent("core", "OnMapLoad", { currentMap }, nullptr);
 }

src/engine/vgui/screentext.cpp

@@ -5,14 +5,8 @@
 #include <sdk/schema.h>
 #include <entities/system.h>
 
-std::vector<CEntityKeyValues*> scheduleForDelete;
-
 ScreenText::~ScreenText()
 {
-    if (pScreenEntity.IsValid()) {
-        schema::SetProp<bool>(pScreenEntity.Get(), "CPointWorldText", "m_bEnabled", false);
-        schema::SetProp<bool>(pScreenEntity.Get(), "CPointWorldText", "m_bDrawBackground", false);
-    }
 }
 
 void ScreenText::Create(Color color, std::string font, int size, bool drawBackground, bool isMenu)
@@ -28,8 +22,6 @@ void ScreenText::Create(Color color, std::string font, int size, bool drawBackgr
 
     CEntityKeyValues* pMenuKV = new CEntityKeyValues();
 
-    scheduleForDelete.push_back(pMenuKV);
-
     pMenuKV->SetBool("enabled", true);
     pMenuKV->SetFloat("world_units_per_pixel", (0.25 / 1050) * size);
     pMenuKV->SetInt("justify_horizontal", 0);
@@ -198,11 +190,4 @@ bool ScreenText::IsRenderingTo(CHandle<CEntityInstance> renderingTo)
 void ScreenText::SetRenderingTo(CEntityInstance* ent)
 {
     pRenderingTo.Set(ent);
-}
-
-void EraseScheduledCEntKeyVals() {
-    // for (auto e : scheduleForDelete) {
-    //     delete e;
-    // }
-    scheduleForDelete.clear();
 }