fix(menus): Center Menu crashing on exit

Author: skuzzis

src/network/usermessages/usermessages.cpp

@@ -19,16 +19,19 @@ void UserMessages::Initialize()
 {
     SH_ADD_HOOK_MEMFUNC(IGameEventSystem, PostEventAbstract, g_pGameEventSystem, this, &UserMessages::PostEvent, false);
 
+    #ifndef _WIN32
     DynLibUtils::CModule eng = DetermineModuleByLibrary("engine2");
     void* serverSideClientVTable = FindVirtTable(&eng, "CServerSideClient", g_GameData.GetOffset("INetworkMessageProcessingPreFilter"));
 
     hookID = SH_ADD_MANUALDVPHOOK(FilterMessage, serverSideClientVTable, SH_MEMBER(this, &UserMessages::FilterMessage), false);
+    #endif
 }
 
 bool UserMessages::FilterMessage(const CNetMessage* cMsg, INetChannel* netchan)
 {
     auto client = META_IFACEPTR(CServerSideClient);
     if (!client) RETURN_META_VALUE(MRES_IGNORED, true);
+    if (!cMsg) RETURN_META_VALUE(MRES_IGNORED, true);
 
     UserMessage um(cMsg->GetNetMessage(), const_cast<CNetMessage*>(cMsg), (uint64_t*)0);
     ClassData* umobj = new ClassData({ { "um_ptr", &um } }, "UserMessage", nullptr);
@@ -43,9 +46,11 @@ bool UserMessages::FilterMessage(const CNetMessage* cMsg, INetChannel* netchan)
 void UserMessages::Destroy()
 {
     SH_REMOVE_HOOK_MEMFUNC(IGameEventSystem, PostEventAbstract, g_pGameEventSystem, this, &UserMessages::PostEvent, false);
-
+    
+    #ifndef _WIN32
     SH_REMOVE_HOOK_ID(hookID);
     hookID = -1;
+    #endif
 }
 
 void UserMessages::PostEvent(CSplitScreenSlot nSlot, bool bLocalOnly, int nClientCount, const uint64* clients, INetworkMessageInternal* pEvent, const CNetMessage* pData, unsigned long nSize, NetChannelBufType_t bufType)

src/scripting/server/menus.cpp

@@ -31,7 +31,7 @@ LoadScriptingComponent(menus, [](PluginObject plugin, EContext* ctx) -> void {
         std::string title = context->GetArgumentOr<std::string>(1, "");
         std::string color = context->GetArgumentOr<std::string>(2, "");
         std::vector<std::pair<std::string, std::string>> options = context->GetArgumentOr<std::vector<std::pair<std::string, std::string>>>(3, std::vector<std::pair<std::string, std::string>>{});
-        std::string menuKind = context->GetArgumentOr<std::string>(4, g_Config.FetchValue<std::string>("core.menu.kind"));
+        std::string menuKind = WIN_LINUX("center", context->GetArgumentOr<std::string>(4, g_Config.FetchValue<std::string>("core.menu.kind")));
 
         g_MenuManager.RegisterMenu(FetchPluginName(context->GetPluginContext()), menuid, title, color, options, true, menuKind);
     });

src/server/menus/MenuRenderer.cpp

@@ -93,9 +93,8 @@ void MenuRenderer::HideMenu()
     std::string kind = menu->GetKind();
     if (kind == "center") {
         if (centerMessageEvent) {
-            centerMessageEvent->SetString("loc_token", "Exiting...");
-            g_GameData.FetchSignature<GetLegacyGameEventListener>("LegacyGameEventListener")(m_player->GetSlot())->FireGameEvent(centerMessageEvent);
             g_gameEventManager->FreeEvent(centerMessageEvent);
+            centerMessageEvent = nullptr;
         }
     }
     else if (kind == "screen") {