Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions lib/Sema/CSOptimizer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1316,27 +1316,20 @@ static void determineBestChoicesInContext(
return 0.3;
}

auto &ctx = cs.getASTContext();

// Check if the other side conforms to `ExpressibleByArrayLiteral`
// protocol (in some way). We want an overly optimistic result
// here to avoid under-favoring.
if (candidateType->isArray() &&
checkConformanceWithoutContext(
paramType,
ctx.getProtocol(KnownProtocolKind::ExpressibleByArrayLiteral),
/*allowMissing=*/true))
TypeChecker::conformsToKnownProtocol(
paramType, KnownProtocolKind::ExpressibleByArrayLiteral))
return 0.3;

// Check if the other side conforms to
// `ExpressibleByDictionaryLiteral` protocol (in some way).
// We want an overly optimistic result here to avoid under-favoring.
if (candidateType->isDictionary() &&
checkConformanceWithoutContext(
paramType,
ctx.getProtocol(
KnownProtocolKind::ExpressibleByDictionaryLiteral),
/*allowMissing=*/true))
TypeChecker::conformsToKnownProtocol(
paramType, KnownProtocolKind::ExpressibleByDictionaryLiteral))
return 0.3;
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// RUN: %scale-test --begin 1 --end 15 --step 1 --select NumLeafScopes %s
// REQUIRES: asserts,no_asan

struct MyIntValue: ExpressibleByArrayLiteral {
init(arrayLiteral: Int...) {}
}

func +(x: MyIntValue, y: MyIntValue) -> MyIntValue { [] }
func +(x: MyIntValue, y: Int) -> MyIntValue { [] }

func test(y: Int) {
%for i in range(0, N):
[1] + y +
%end
[1] + y
}