Fix TypeLowering: BitwiseCopyable archetypes are trivial #85455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked on a SILGen issue with keypath setter thunks. When Scalar is considered trivial, SILGen omits the temporary allocation for the
@inargument. In general, we should assume that@inmay modify the contents of its address even if it is trivial. The callee might not be able to see that it is a trivial type and attempt todestroy it. We might want it to be legal for that destroy to zero the memory.
A similar bug was fixed here:
dc95b11
The current blocker is: