Ensure xUnit/JUnit XML output correctly counts test-less issues. (#597)

This PR ensures that issues that occur on detached tasks are recorded in
the XML output provided by Swift Testing.

I also took a moment to improve test coverage a bit for the XML
recorder.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.

Author: grynspan

Sources/Testing/Events/Recorder/Event.JUnitXMLRecorder.swift

@@ -33,6 +33,9 @@ extension Event {
       /// This value does not include test suites.
       var testCount = 0
 
+      /// Any recorded issues where the test was not known.
+      var issuesForUnknownTests = [Issue]()
+
       /// A type describing data tracked on a per-test basis.
       struct TestData: Sendable {
         /// The ID of the test.
@@ -122,19 +125,22 @@ extension Event.JUnitXMLRecorder {
       if issue.isKnown {
         return nil
       }
-      guard let id = test?.id else {
-        return nil // FIXME: handle issues without known tests
-      }
-      let keyPath = id.keyPathRepresentation
-      _context.withLock { context in
-        context.testData[keyPath]?.issues.append(issue)
+      if let id = test?.id {
+        let keyPath = id.keyPathRepresentation
+        _context.withLock { context in
+          context.testData[keyPath]?.issues.append(issue)
+        }
+      } else {
+        _context.withLock { context in
+          context.issuesForUnknownTests.append(issue)
+        }
       }
       return nil
     case .runEnded:
       return _context.withLock { context in
         let issueCount = context.testData
           .compactMap(\.value?.issues.count)
-          .reduce(into: 0, +=)
+          .reduce(into: 0, +=) + context.issuesForUnknownTests.count
         let skipCount = context.testData
           .compactMap(\.value?.skipInfo)
           .count
@@ -218,7 +224,7 @@ extension Event.JUnitXMLRecorder {
       ">"
     case "&":
       "&"
-    case _ where !character.isASCII:
+    case _ where !character.isASCII || character.isNewline:
       character.unicodeScalars.lazy
         .map(\.value)
         .map { "&#\($0);" }

Tests/TestingTests/EventRecorderTests.swift

@@ -360,13 +360,32 @@ struct EventRecorderTests {
   }
 #endif
 
-  @Test("Recorded issues may not have associated tests")
-  func issueWithoutTest() {
+  @Test("HumanReadableOutputRecorder counts issues without associated tests")
+  func humanReadableRecorderCountsIssuesWithoutTests() {
     let issue = Issue(kind: .unconditional, comments: [], sourceContext: .init())
     let event = Event(.issueRecorded(issue), testID: nil, testCaseID: nil)
     let context = Event.Context(test: nil, testCase: nil)
 
     let recorder = Event.HumanReadableOutputRecorder()
+    let messages = recorder.record(event, in: context)
+    #expect(
+      messages.map(\.stringValue).contains { message in
+        message.contains("unknown")
+      }
+    )
+  }
+
+  @Test("JUnitXMLRecorder counts issues without associated tests")
+  func junitRecorderCountsIssuesWithoutTests() async throws {
+    let issue = Issue(kind: .unconditional, comments: [], sourceContext: .init())
+    let event = Event(.issueRecorded(issue), testID: nil, testCaseID: nil)
+    let context = Event.Context(test: nil, testCase: nil)
+
+    let recorder = Event.JUnitXMLRecorder { string in
+      if string.contains("<testsuite") {
+        #expect(string.contains(#"failures=1"#))
+      }
+    }
     _ = recorder.record(event, in: context)
   }
 }
@@ -379,6 +398,7 @@ struct EventRecorderTests {
     await { () async in
       _ = Issue.record("Whales fail asynchronously.")
     }()
+    Issue.record("Whales\nalso\nfall.")
   }
   @Test(.hidden) func expectantKangaroo() {
     #expect("abc" == "xyz")
@@ -449,6 +469,10 @@ struct EventRecorderTests {
   @Test(.hidden) func cornyUnicorn🦄() throws {
     throw MyDescriptiveError(description: #"🦄"#)
   }
+
+  @Test(.hidden) func burdgeoningBudgerigar() {
+    Issue.record(#"</>& "Down\#nwe\#ngo!""#)
+  }
 }
 
 @Suite(.hidden) struct PredictablyFailingTests {