From 17fc48fa696d2209aa4ac856ef87a0968f031fe2 Mon Sep 17 00:00:00 2001
From: Konrad Malawski <ktoso@apple.com>
Date: Tue, 30 Jun 2026 09:58:41 +0900
Subject: [PATCH] Thunks may be to deprecated apis, so ignore deprecation
 warnings inside them

Otherwise we get absolutely flooded with deprecation warnings since
we're bridging to deprecated APIs which we do want to keep, but do not
want to be warned about this;
---
 .../FFMSwift2JavaGenerator+FunctionLowering.swift     |  3 +++
 .../FFMSwift2JavaGenerator+SwiftThunkPrinting.swift   |  6 ++++++
 .../JNISwift2JavaGenerator+SwiftThunkPrinting.swift   |  3 +++
 .../Asserts/LoweringAssertions.swift                  | 11 +++++++++--
 .../JNI/JNICDeclAttributesTests.swift                 | 10 ++++++++--
 5 files changed, 29 insertions(+), 4 deletions(-)

diff --git a/Sources/JExtractSwiftLib/FFM/CDeclLowering/FFMSwift2JavaGenerator+FunctionLowering.swift b/Sources/JExtractSwiftLib/FFM/CDeclLowering/FFMSwift2JavaGenerator+FunctionLowering.swift
index 4fce2e430..e6a22786a 100644
--- a/Sources/JExtractSwiftLib/FFM/CDeclLowering/FFMSwift2JavaGenerator+FunctionLowering.swift
+++ b/Sources/JExtractSwiftLib/FFM/CDeclLowering/FFMSwift2JavaGenerator+FunctionLowering.swift
@@ -979,6 +979,9 @@ extension LoweredFunctionSignature {
 
     var loweredCDecl = try! FunctionDeclSyntax(
       """
+      #if compiler(>=6.4)
+      @diagnose(DeprecatedDeclaration, as: ignored)
+      #endif
       @_cdecl(\(literal: cName))
       public func \(raw: cName)(\(raw: cdeclParams))\(raw: returnClause) {
       }
diff --git a/Sources/JExtractSwiftLib/FFM/FFMSwift2JavaGenerator+SwiftThunkPrinting.swift b/Sources/JExtractSwiftLib/FFM/FFMSwift2JavaGenerator+SwiftThunkPrinting.swift
index 0247c7897..c78cb8688 100644
--- a/Sources/JExtractSwiftLib/FFM/FFMSwift2JavaGenerator+SwiftThunkPrinting.swift
+++ b/Sources/JExtractSwiftLib/FFM/FFMSwift2JavaGenerator+SwiftThunkPrinting.swift
@@ -241,6 +241,9 @@ struct SwiftThunkTranslator {
 
     return
       """
+      #if compiler(>=6.4)
+      @diagnose(DeprecatedDeclaration, as: ignored)
+      #endif
       @_cdecl("\(raw: funcName)")
       public func \(raw: funcName)() -> UnsafeMutableRawPointer /* Any.Type */ {
         return unsafeBitCast(\(raw: nominal.swiftNominal.qualifiedName).self, to: UnsafeMutableRawPointer.self)
@@ -285,6 +288,9 @@ struct SwiftThunkTranslator {
 
     let copyBytesThunk: DeclSyntax =
       """
+      #if compiler(>=6.4)
+      @diagnose(DeprecatedDeclaration, as: ignored)
+      #endif
       @_cdecl("\(raw: thunkName)")
       public func \(raw: thunkName)(
           selfPointer: UnsafeRawPointer,
diff --git a/Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift b/Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift
index 5d976619c..14e075b02 100644
--- a/Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift
+++ b/Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift
@@ -788,6 +788,9 @@ extension JNISwift2JavaGenerator {
       #if compiler(>=6.3)
       @used
       #endif
+      #if compiler(>=6.4)
+      @diagnose(DeprecatedDeclaration, as: ignored)
+      #endif
       @_cdecl("\(cName)")
       public func \(cName)(\(thunkParameters.joined(separator: ", ")))\(thunkReturnType)
       """
diff --git a/Tests/JExtractSwiftTests/Asserts/LoweringAssertions.swift b/Tests/JExtractSwiftTests/Asserts/LoweringAssertions.swift
index 645a29133..75a5c1b5e 100644
--- a/Tests/JExtractSwiftTests/Asserts/LoweringAssertions.swift
+++ b/Tests/JExtractSwiftTests/Asserts/LoweringAssertions.swift
@@ -18,6 +18,13 @@ import SwiftJavaConfigurationShared
 import SwiftSyntax
 import Testing
 
+private let thunkDiagnoseAttribute = """
+  #if compiler(>=6.4)
+  @diagnose(DeprecatedDeclaration, as: ignored)
+  #endif
+
+  """
+
 /// Assert that the lowering of the function function declaration to a @_cdecl
 /// entrypoint matches the expected form.
 func assertLoweredFunction(
@@ -79,7 +86,7 @@ func assertLoweredFunction(
   )
 
   #expect(
-    loweredCDecl.description == expectedCDecl.description,
+    loweredCDecl.description == thunkDiagnoseAttribute + expectedCDecl.description,
     sourceLocation: Testing.SourceLocation(
       fileID: fileID,
       filePath: filePath,
@@ -147,7 +154,7 @@ func assertLoweredVariableAccessor(
   )
 
   #expect(
-    loweredCDecl?.description == expectedCDecl?.description,
+    loweredCDecl?.description == expectedCDecl.map { thunkDiagnoseAttribute + $0.description },
     sourceLocation: Testing.SourceLocation(
       fileID: fileID,
       filePath: filePath,
diff --git a/Tests/JExtractSwiftTests/JNI/JNICDeclAttributesTests.swift b/Tests/JExtractSwiftTests/JNI/JNICDeclAttributesTests.swift
index 9ac42d5ac..c944a1720 100644
--- a/Tests/JExtractSwiftTests/JNI/JNICDeclAttributesTests.swift
+++ b/Tests/JExtractSwiftTests/JNI/JNICDeclAttributesTests.swift
@@ -19,7 +19,7 @@ import Testing
 struct JNICDeclAttributesTests {
 
   @Test
-  func globalFunc_hasUsedAttribute() throws {
+  func globalFunc_hasThunkAttributes() throws {
     try assertOutput(
       input: "public func hello()",
       .jni,
@@ -29,6 +29,9 @@ struct JNICDeclAttributesTests {
         #if compiler(>=6.3)
         @used
         #endif
+        #if compiler(>=6.4)
+        @diagnose(DeprecatedDeclaration, as: ignored)
+        #endif
         @_cdecl("Java_com_example_swift_SwiftModule__00024hello__")
         ...
         """
@@ -37,7 +40,7 @@ struct JNICDeclAttributesTests {
   }
 
   @Test
-  func globalFuncWithArgs_hasUsedAttribute() throws {
+  func globalFuncWithArgs_hasThunkAttributes() throws {
     try assertOutput(
       input: "public func add(a: Int64, b: Int64) -> Int64",
       .jni,
@@ -47,6 +50,9 @@ struct JNICDeclAttributesTests {
         #if compiler(>=6.3)
         @used
         #endif
+        #if compiler(>=6.4)
+        @diagnose(DeprecatedDeclaration, as: ignored)
+        #endif
         @_cdecl("Java_com_example_swift_SwiftModule__00024add__JJ")
         ...
         """