Use Hashes for swiftmodule incremental compilation #2033
+64
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed this in my earlier work on using hashes for Swift Incremental compilation.
Contributor
|
Could you lease add a test which would fail prior to this change? |
Contributor
Author
|
Added a test that emit-module is now skipped, and a sanity test that it is still run when file contents change, even with this feature enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this in my earlier work on using hashes for Swift Incremental compilation.
(#1923)
Without this, we can have compiles that skip all recompilation save the emission of an identical Swiftmodule.