Enable 6.2 CI and enable Windows CI

FranzBusch · FranzBusch · commit 13ffa92129eb · 2025-09-22T15:28:43.000+02:00
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -11,12 +11,16 @@ jobs:
     name: Unit tests
     uses: apple/swift-nio/.github/workflows/unit_tests.yml@main
     with:
-      linux_5_9_arguments_override: "--explicit-target-dependency-import-check error"
-      linux_5_10_arguments_override: "--explicit-target-dependency-import-check error"
       linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
       linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
-      linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
+      linux_6_2_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
+      linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
       linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
+      windows_6_0_enabled: true
+      windows_6_1_enabled: true
+      windows_6_2_enabled: true
+      windows_nightly_next_enabled: true
+      windows_nightly_main_enabled: true
 
   cxx-interop:
     name: Cxx interop
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -15,12 +15,16 @@ jobs:
     name: Unit tests
     uses: apple/swift-nio/.github/workflows/unit_tests.yml@main
     with:
-      linux_5_9_arguments_override: "--explicit-target-dependency-import-check error"
-      linux_5_10_arguments_override: "--explicit-target-dependency-import-check error"
       linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
       linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
-      linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
+      linux_6_2_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
+      linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
       linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
+      windows_6_0_enabled: true
+      windows_6_1_enabled: true
+      windows_6_2_enabled: true
+      windows_nightly_next_enabled: true
+      windows_nightly_main_enabled: true
 
   cxx-interop:
     name: Cxx interop
diff --git a/Sources/UnixSignals/UnixSignal.swift b/Sources/UnixSignals/UnixSignal.swift
@@ -26,6 +26,8 @@ import Dispatch
 /// A struct representing a Unix signal.
 ///
 /// Signals are standardized messages sent to a running program to trigger specific behavior, such as quitting or error handling
+///
+/// - Important: Unix signals are only functional on platforms supporting signals.
 public struct UnixSignal: Hashable, Sendable, CustomStringConvertible {
     internal enum Wrapped {
         case sigabrt
@@ -118,6 +120,9 @@ extension UnixSignal.Wrapped: CustomStringConvertible {
 
 extension UnixSignal.Wrapped {
     var rawValue: Int32 {
+        #if os(Windows)
+        return -1
+        #else
         switch self {
         case .sigabrt:
             return SIGABRT
@@ -146,5 +151,6 @@ extension UnixSignal.Wrapped {
         case .sigpipe:
             return SIGPIPE
         }
+        #endif
     }
 }
diff --git a/Sources/UnixSignals/UnixSignalsSequence.swift b/Sources/UnixSignals/UnixSignalsSequence.swift
@@ -15,14 +15,15 @@
 #if canImport(Darwin)
 import Darwin
 import Dispatch
-#elseif canImport(Glibc)
+#else
 @preconcurrency import Dispatch
+#endif
+
+#if canImport(Glibc)
 import Glibc
 #elseif canImport(Musl)
-@preconcurrency import Dispatch
 import Musl
 #elseif canImport(Android)
-@preconcurrency import Dispatch
 import Android
 #endif
 import ConcurrencyHelpers
diff --git a/Tests/ServiceLifecycleTests/ServiceGroupAddServiceTests.swift b/Tests/ServiceLifecycleTests/ServiceGroupAddServiceTests.swift
@@ -239,6 +239,7 @@ final class ServiceGroupAddServiceTests: XCTestCase {
         }
     }
 
+    #if !os(Windows)
     func testGracefulShutdownOrdering_withAddedServices() async throws {
         let service1 = MockService(description: "Service1")
         let service2 = MockService(description: "Service2")
@@ -369,6 +370,7 @@ final class ServiceGroupAddServiceTests: XCTestCase {
             await service2.resumeRunContinuation(with: .success(()))
         }
     }
+    #endif
 
     // MARK: - Helpers
 
diff --git a/Tests/ServiceLifecycleTests/ServiceGroupTests.swift b/Tests/ServiceLifecycleTests/ServiceGroupTests.swift
@@ -81,6 +81,7 @@ final class ServiceGroupTests: XCTestCase {
         }
     }
 
+    #if !os(Windows)
     func test_whenRun_ShutdownGracefully() async throws {
         let mockService = MockService(description: "Service1")
         let serviceGroup = self.makeServiceGroup(
@@ -103,6 +104,7 @@ final class ServiceGroupTests: XCTestCase {
             await mockService.resumeRunContinuation(with: .success(()))
         }
     }
+    #endif
 
     func testRun_whenServiceExitsEarly() async throws {
         let mockService = MockService(description: "Service1")
@@ -469,6 +471,7 @@ final class ServiceGroupTests: XCTestCase {
         }
     }
 
+    #if !os(Windows)
     func testCancellationSignal() async throws {
         let service1 = MockService(description: "Service1")
         let service2 = MockService(description: "Service2")
@@ -507,7 +510,9 @@ final class ServiceGroupTests: XCTestCase {
             await XCTAsyncAssertNoThrow(try await group.next())
         }
     }
+    #endif
 
+    #if !os(Windows)
     func testCancellationSignal_afterGracefulShutdownSignal() async throws {
         let service1 = MockService(description: "Service1")
         let service2 = MockService(description: "Service2")
@@ -560,7 +565,9 @@ final class ServiceGroupTests: XCTestCase {
             await XCTAsyncAssertNoThrow(try await group.next())
         }
     }
+    #endif
 
+    #if !os(Windows)
     func testGracefulShutdownOrdering() async throws {
         let service1 = MockService(description: "Service1")
         let service2 = MockService(description: "Service2")
@@ -624,7 +631,9 @@ final class ServiceGroupTests: XCTestCase {
             await service1.resumeRunContinuation(with: .success(()))
         }
     }
+    #endif
 
+    #if !os(Windows)
     func testGracefulShutdownOrdering_whenServiceThrows() async throws {
         let service1 = MockService(description: "Service1")
         let service2 = MockService(description: "Service2")
@@ -688,7 +697,9 @@ final class ServiceGroupTests: XCTestCase {
             }
         }
     }
+    #endif
 
+    #if !os(Windows)
     func testGracefulShutdownOrdering_whenServiceThrows_andServiceGracefullyShutsdown() async throws {
         let service1 = MockService(description: "Service1")
         let service2 = MockService(description: "Service2")
@@ -756,7 +767,9 @@ final class ServiceGroupTests: XCTestCase {
             }
         }
     }
+    #endif
 
+    #if !os(Windows)
     func testGracefulShutdownOrdering_whenServiceExits() async throws {
         let service1 = MockService(description: "Service1")
         let service2 = MockService(description: "Service2")
@@ -816,7 +829,9 @@ final class ServiceGroupTests: XCTestCase {
             await service2.resumeRunContinuation(with: .success(()))
         }
     }
+    #endif
 
+    #if !os(Windows)
     func testGracefulShutdownOrdering_whenServiceExits_andIgnoringThrows() async throws {
         let service1 = MockService(description: "Service1")
         let service2 = MockService(description: "Service2")
@@ -886,7 +901,9 @@ final class ServiceGroupTests: XCTestCase {
             }
         }
     }
+    #endif
 
+    #if !os(Windows)
     func testNestedServiceLifecycle() async throws {
         struct NestedGroupService: Service {
             let group: ServiceGroup
@@ -1007,6 +1024,7 @@ final class ServiceGroupTests: XCTestCase {
             await service2.resumeRunContinuation(with: .success(()))
         }
     }
+    #endif
 
     func testGracefulShutdownEscalation() async throws {
         let mockService = MockService(description: "Service1")
diff --git a/Tests/UnixSignalsTests/UnixSignalTests.swift b/Tests/UnixSignalsTests/UnixSignalTests.swift
@@ -12,6 +12,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+#if !os(Windows)
+
 import UnixSignals
 import XCTest
 #if canImport(Darwin)
@@ -154,3 +156,5 @@ final class UnixSignalTests: XCTestCase {
         await task.value
     }
 }
+
+#endif

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,7 @@ final class ServiceGroupAddServiceTests: XCTestCase {`
`239`	`239`	`}`
`240`	`240`	`}`
`241`	`241`
	`242`	`+ #if !os(Windows)`
`242`	`243`	`func testGracefulShutdownOrdering_withAddedServices() async throws {`
`243`	`244`	`let service1 = MockService(description: "Service1")`
`244`	`245`	`let service2 = MockService(description: "Service2")`
`@@ -369,6 +370,7 @@ final class ServiceGroupAddServiceTests: XCTestCase {`
`369`	`370`	`await service2.resumeRunContinuation(with: .success(()))`
`370`	`371`	`}`
`371`	`372`	`}`
	`373`	`+ #endif`
`372`	`374`
`373`	`375`	`// MARK: - Helpers`
`374`	`376`
Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ final class ServiceGroupTests: XCTestCase {`
`81`	`81`	`}`
`82`	`82`	`}`
`83`	`83`
	`84`	`+ #if !os(Windows)`
`84`	`85`	`func test_whenRun_ShutdownGracefully() async throws {`
`85`	`86`	`let mockService = MockService(description: "Service1")`
`86`	`87`	`let serviceGroup = self.makeServiceGroup(`
`@@ -103,6 +104,7 @@ final class ServiceGroupTests: XCTestCase {`
`103`	`104`	`await mockService.resumeRunContinuation(with: .success(()))`
`104`	`105`	`}`
`105`	`106`	`}`
	`107`	`+ #endif`
`106`	`108`
`107`	`109`	`func testRun_whenServiceExitsEarly() async throws {`
`108`	`110`	`let mockService = MockService(description: "Service1")`
`@@ -469,6 +471,7 @@ final class ServiceGroupTests: XCTestCase {`
`469`	`471`	`}`
`470`	`472`	`}`
`471`	`473`
	`474`	`+ #if !os(Windows)`
`472`	`475`	`func testCancellationSignal() async throws {`
`473`	`476`	`let service1 = MockService(description: "Service1")`
`474`	`477`	`let service2 = MockService(description: "Service2")`
`@@ -507,7 +510,9 @@ final class ServiceGroupTests: XCTestCase {`
`507`	`510`	`await XCTAsyncAssertNoThrow(try await group.next())`
`508`	`511`	`}`
`509`	`512`	`}`
	`513`	`+ #endif`
`510`	`514`
	`515`	`+ #if !os(Windows)`
`511`	`516`	`func testCancellationSignal_afterGracefulShutdownSignal() async throws {`
`512`	`517`	`let service1 = MockService(description: "Service1")`
`513`	`518`	`let service2 = MockService(description: "Service2")`
`@@ -560,7 +565,9 @@ final class ServiceGroupTests: XCTestCase {`
`560`	`565`	`await XCTAsyncAssertNoThrow(try await group.next())`
`561`	`566`	`}`
`562`	`567`	`}`
	`568`	`+ #endif`
`563`	`569`
	`570`	`+ #if !os(Windows)`
`564`	`571`	`func testGracefulShutdownOrdering() async throws {`
`565`	`572`	`let service1 = MockService(description: "Service1")`
`566`	`573`	`let service2 = MockService(description: "Service2")`
`@@ -624,7 +631,9 @@ final class ServiceGroupTests: XCTestCase {`
`624`	`631`	`await service1.resumeRunContinuation(with: .success(()))`
`625`	`632`	`}`
`626`	`633`	`}`
	`634`	`+ #endif`
`627`	`635`
	`636`	`+ #if !os(Windows)`
`628`	`637`	`func testGracefulShutdownOrdering_whenServiceThrows() async throws {`
`629`	`638`	`let service1 = MockService(description: "Service1")`
`630`	`639`	`let service2 = MockService(description: "Service2")`
`@@ -688,7 +697,9 @@ final class ServiceGroupTests: XCTestCase {`
`688`	`697`	`}`
`689`	`698`	`}`
`690`	`699`	`}`
	`700`	`+ #endif`
`691`	`701`
	`702`	`+ #if !os(Windows)`
`692`	`703`	`func testGracefulShutdownOrdering_whenServiceThrows_andServiceGracefullyShutsdown() async throws {`
`693`	`704`	`let service1 = MockService(description: "Service1")`
`694`	`705`	`let service2 = MockService(description: "Service2")`
`@@ -756,7 +767,9 @@ final class ServiceGroupTests: XCTestCase {`
`756`	`767`	`}`
`757`	`768`	`}`
`758`	`769`	`}`
	`770`	`+ #endif`
`759`	`771`
	`772`	`+ #if !os(Windows)`
`760`	`773`	`func testGracefulShutdownOrdering_whenServiceExits() async throws {`
`761`	`774`	`let service1 = MockService(description: "Service1")`
`762`	`775`	`let service2 = MockService(description: "Service2")`
`@@ -816,7 +829,9 @@ final class ServiceGroupTests: XCTestCase {`
`816`	`829`	`await service2.resumeRunContinuation(with: .success(()))`
`817`	`830`	`}`
`818`	`831`	`}`
	`832`	`+ #endif`
`819`	`833`
	`834`	`+ #if !os(Windows)`
`820`	`835`	`func testGracefulShutdownOrdering_whenServiceExits_andIgnoringThrows() async throws {`
`821`	`836`	`let service1 = MockService(description: "Service1")`
`822`	`837`	`let service2 = MockService(description: "Service2")`
`@@ -886,7 +901,9 @@ final class ServiceGroupTests: XCTestCase {`
`886`	`901`	`}`
`887`	`902`	`}`
`888`	`903`	`}`
	`904`	`+ #endif`
`889`	`905`
	`906`	`+ #if !os(Windows)`
`890`	`907`	`func testNestedServiceLifecycle() async throws {`
`891`	`908`	`struct NestedGroupService: Service {`
`892`	`909`	`let group: ServiceGroup`
`@@ -1007,6 +1024,7 @@ final class ServiceGroupTests: XCTestCase {`
`1007`	`1024`	`await service2.resumeRunContinuation(with: .success(()))`
`1008`	`1025`	`}`
`1009`	`1026`	`}`
	`1027`	`+ #endif`
`1010`	`1028`
`1011`	`1029`	`func testGracefulShutdownEscalation() async throws {`
`1012`	`1030`	`let mockService = MockService(description: "Service1")`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,8 @@`
`12`	`12`	`//`
`13`	`13`	`//===----------------------------------------------------------------------===//`
`14`	`14`
	`15`	`+#if !os(Windows)`
	`16`	`+`
`15`	`17`	`import UnixSignals`
`16`	`18`	`import XCTest`
`17`	`19`	`#if canImport(Darwin)`
`@@ -154,3 +156,5 @@ final class UnixSignalTests: XCTestCase {`
`154`	`156`	`await task.value`
`155`	`157`	`}`
`156`	`158`	`}`
	`159`	`+`
	`160`	`+#endif`