don't use FailAction, always cancel redirectTask on fail

Author: gregcotten

Sources/AsyncHTTPClient/RequestBag+StateMachine.swift

@@ -594,7 +594,6 @@ extension RequestBag.StateMachine {
     enum FailAction {
         case failTask(Error, HTTPRequestScheduler?, HTTPRequestExecutor?)
         case cancelExecutor(HTTPRequestExecutor)
-        case propagateCancellation
         case none
     }
 
@@ -625,11 +624,8 @@ extension RequestBag.StateMachine {
             self.state = .finished(error: error)
             return .failTask(error, nil, nil)
         case .finished(.none):
-            if (error as? HTTPClientError) == .cancelled {
-                return .propagateCancellation
-            } else {
-                return .none
-            }
+            // An error occurred after the request has finished. Ignore...
+            return .none
         case .deadlineExceededWhileQueued:
             let realError: Error = {
                 if (error as? HTTPClientError) == .cancelled {

Sources/AsyncHTTPClient/RequestBag.swift

@@ -361,6 +361,8 @@ final class RequestBag<Delegate: HTTPClientResponseDelegate> {
         let action = self.state.fail(error)
 
         self.executeFailAction0(action)
+
+        self.redirectTask?.cancel()
     }
 
     private func executeFailAction0(_ action: RequestBag<Delegate>.StateMachine.FailAction) {
@@ -371,8 +373,6 @@ final class RequestBag<Delegate: HTTPClientResponseDelegate> {
             self.failTask0(error)
         case .cancelExecutor(let executor):
             executor.cancelRequest(self)
-        case .propagateCancellation:
-            self.redirectTask?.cancel()
         case .none:
             break
         }