split schemas derived from different origins and pointing to same $ref

Author: vearutop

src/Schema.php

@@ -706,6 +706,9 @@ private function processObject($data, Context $options, $path, $result = null)
                         try {
                             $refResult = $this->process($data, $options, $path . '->$ref:' . $refString, $result);
                             if ($refResult instanceof ObjectItemContract) {
+                                if ($refResult->getFromRefs()) {
+                                    $refResult = clone $refResult; // @todo check performance, consider option
+                                }
                                 $refResult->setFromRef($refString);
                             }
                             $ref->setImported($refResult);

tests/src/Helper/DeepRefAnotherTitle.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace Swaggest\JsonSchema\Tests\Helper;
+
+
+use Swaggest\JsonSchema\Constraint\Properties;
+use Swaggest\JsonSchema\Schema;
+use Swaggest\JsonSchema\Structure\ClassStructure;
+
+class DeepRefAnotherTitle extends ClassStructure
+{
+    /**
+     * @param Properties|static $properties
+     * @param Schema $ownerSchema
+     */
+    public static function setUpProperties($properties, Schema $ownerSchema)
+    {
+        $ownerSchema->setFromRef('http://json-schema.org/draft-04/schema#/properties/title');
+        $ownerSchema->setFromRef('#/definitions/anotherTitle');
+    }
+
+}

tests/src/Helper/DeepRefRoot.php

@@ -13,6 +13,8 @@ class DeepRefRoot extends ClassStructure
 
     public $intermediateTitle;
 
+    public $anotherTitle;
+
     public $prop;
 
     /**
@@ -28,6 +30,8 @@ public static function setUpProperties($properties, Schema $ownerSchema)
 
         $properties->intermediateTitle = DeepRefTitle::schema();
 
+        $properties->anotherTitle = DeepRefAnotherTitle::schema();
+
         $ownerSchema->type = Schema::STRING;
     }
 }

tests/src/PHPUnit/ClassStructure/ExportSchemaTest.php

@@ -51,6 +51,9 @@ public function testDeepRef()
         },
         "intermediateTitle": {
             "$ref": "#/definitions/title"
+        },
+        "anotherTitle": {
+            "$ref": "#/definitions/anotherTitle"
         }
     },
     "type": "string",
@@ -69,6 +72,9 @@ public function testDeepRef()
         },
         "title": {
             "$ref": "http://json-schema.org/draft-04/schema#/properties/title"
+        },
+        "anotherTitle": {
+            "$ref": "http://json-schema.org/draft-04/schema#/properties/title"
         }
     }
 }
@@ -95,11 +101,23 @@ public function testDeepRefSchema()
         },
         "lvl4": {
             "type": "integer"
+        },
+        "title": {
+            "$ref": "http://json-schema.org/draft-04/schema#/properties/title"
+        },
+        "anotherTitle": {
+            "$ref": "http://json-schema.org/draft-04/schema#/properties/title"
         }
     },
     "properties": {
         "prop": {
             "$ref": "#/definitions/lvl1"
+        },
+        "intermediateTitle": {
+            "$ref": "#/definitions/title"
+        },
+        "anotherTitle": {
+            "$ref": "#/definitions/anotherTitle"
         }
     },
     "type": "object"