fix: improve unowned derived performance (#14724)

trueadm · web-flow · commit 699dc6e4f7bb · 2024-12-16T20:05:08.000Z
* fix: improve unowned derived performance

* fix: improve unowned derived performance

* changeset
diff --git a/.changeset/many-worms-attend.md b/.changeset/many-worms-attend.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: improve unowned derived performance
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -230,8 +230,9 @@ export function check_dirtiness(reaction) {
 			}
 		}
 
-		// Unowned signals should never be marked as clean.
-		if (!is_unowned) {
+		// Unowned signals should never be marked as clean unless they
+		// are used within an active_effect without skip_reaction
+		if (!is_unowned || (active_effect !== null && !skip_reaction)) {
 			set_signal_status(reaction, CLEAN);
 		}
 	}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +fix: improve unowned derived performance
Original file line number	Diff line number	Diff line change
`@@ -230,8 +230,9 @@ export function check_dirtiness(reaction) {`
`230`	`230`	`}`
`231`	`231`	`}`
`232`	`232`
`233`		`- // Unowned signals should never be marked as clean.`
`234`		`- if (!is_unowned) {`
	`233`	`+ // Unowned signals should never be marked as clean unless they`
	`234`	`+ // are used within an active_effect without skip_reaction`
	`235`	`+ if (!is_unowned \|\| (active_effect !== null && !skip_reaction)) {`
`235`	`236`	`set_signal_status(reaction, CLEAN);`
`236`	`237`	`}`
`237`	`238`	`}`