feat: allow state/derived/props to be explicitly exported from components (#10523)

* Revert "fix: stricter validation for component exports (#10430)"

This reverts commit dab0a43.

* dont remove old changeset

* changeset

* tweak error messages

* make component-exported state work

* consistency

* fix

* fix

* update messages

* update tests

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>

Author: Rich-Harris

.changeset/red-feet-worry.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+feat: allow state/derived/props to be explicitly exported from components

packages/svelte/src/compiler/errors.js

@@ -171,11 +171,9 @@ const runes = {
 	/** @param {string} rune */
 	'invalid-rune-usage': (rune) => `Cannot use ${rune} rune in non-runes mode`,
 	'invalid-state-export': () =>
-		`Cannot export state if it is reassigned. Either export a function returning the state value or only mutate the state value's properties`,
+		`Cannot export state from a module if it is reassigned. Either export a function returning the state value or only mutate the state value's properties`,
 	'invalid-derived-export': () =>
-		`Cannot export derived state. To expose the current derived value, export a function returning its value`,
-	'invalid-prop-export': () =>
-		`Cannot export properties. To expose the current value of a property, export a function returning its value`,
+		`Cannot export derived state from a module. To expose the current derived value, export a function returning its value`,
 	'invalid-props-id': () => `$props() can only be used with an object destructuring pattern`,
 	'invalid-props-pattern': () =>
 		`$props() assignment must not contain nested properties or computed keys`,

packages/svelte/src/compiler/phases/2-analyze/validation.js

@@ -733,10 +733,6 @@ function validate_export(node, scope, name) {
 	const binding = scope.get(name);
 	if (!binding) return;
 
-	if (binding.kind === 'prop') {
-		error(node, 'invalid-prop-export');
-	}
-
 	if (binding.kind === 'derived') {
 		error(node, 'invalid-derived-export');
 	}
@@ -964,25 +960,12 @@ export const validation_runes = merge(validation, a11y_validators, {
 		if (node.label.name !== '$' || path.at(-1)?.type !== 'Program') return;
 		error(node, 'invalid-legacy-reactive-statement');
 	},
-	ExportNamedDeclaration(node, { state, next }) {
+	ExportNamedDeclaration(node, { state }) {
 		if (node.declaration?.type !== 'VariableDeclaration') return;
-
-		// visit children, so bindings are correctly initialised
-		next();
-
-		for (const declarator of node.declaration.declarations) {
-			for (const id of extract_identifiers(declarator.id)) {
-				validate_export(node, state.scope, id.name);
-			}
-		}
-
-		if (state.analysis.instance.scope !== state.scope) return;
 		if (node.declaration.kind !== 'let') return;
+		if (state.analysis.instance.scope !== state.scope) return;
 		error(node, 'invalid-legacy-export');
 	},
-	ExportSpecifier(node, { state }) {
-		validate_export(node, state.scope, node.local.name);
-	},
 	CallExpression(node, { state, path }) {
 		validate_call_expression(node, state.scope, path);
 	},

packages/svelte/src/compiler/phases/3-transform/client/transform-client.js

@@ -225,28 +225,24 @@ export function client_component(source, analysis, options) {
 
 	// Bind static exports to props so that people can access them with bind:x
 	const static_bindings = analysis.exports.map(({ name, alias }) => {
-		const binding = analysis.instance.scope.get(name);
 		return b.stmt(
 			b.call(
 				'$.bind_prop',
 				b.id('$$props'),
 				b.literal(alias ?? name),
-				binding?.kind === 'state' || binding?.kind === 'frozen_state'
-					? b.call('$.get', b.id(name))
-					: b.id(name)
+				serialize_get_binding(b.id(name), instance_state)
 			)
 		);
 	});
 
 	const properties = analysis.exports.map(({ name, alias }) => {
-		const binding = analysis.instance.scope.get(name);
-		const is_source = binding !== null && is_state_source(binding, state);
+		const expression = serialize_get_binding(b.id(name), instance_state);
 
-		if (is_source || options.dev) {
-			return b.get(alias ?? name, [b.return(is_source ? b.call('$.get', b.id(name)) : b.id(name))]);
+		if (expression.type === 'Identifier' && !options.dev) {
+			return b.init(alias ?? name, expression);
 		}
 
-		return b.init(alias ?? name, b.id(name));
+		return b.get(alias ?? name, [b.return(expression)]);
 	});
 
 	if (analysis.accessors) {

packages/svelte/tests/compiler-errors/samples/export-derived-state/_config.js

@@ -4,6 +4,7 @@ export default test({
 	error: {
 		code: 'invalid-derived-export',
 		message:
-			'Cannot export derived state. To expose the current derived value, export a function returning its value'
+			'Cannot export derived state from a module. To expose the current derived value, export a function returning its value',
+		position: [24, 66]
 	}
 });

packages/svelte/tests/compiler-errors/samples/export-derived-state/main.svelte

@@ -4,7 +4,7 @@ export default test({
 	error: {
 		code: 'invalid-state-export',
 		message:
-			"Cannot export state if it is reassigned. Either export a function returning the state value or only mutate the state value's properties",
+			"Cannot export state from a module if it is reassigned. Either export a function returning the state value or only mutate the state value's properties",
 		position: [46, 86]
 	}
 });

packages/svelte/tests/compiler-errors/samples/export-state-2/_config.js

@@ -4,7 +4,7 @@ export default test({
 	error: {
 		code: 'invalid-state-export',
 		message:
-			"Cannot export state if it is reassigned. Either export a function returning the state value or only mutate the state value's properties",
+			"Cannot export state from a module if it is reassigned. Either export a function returning the state value or only mutate the state value's properties",
 		position: [28, 53]
 	}
 });