fix 1372_issue

Author: Narek Mkhitaryan

src/superannotate/lib/core/__init__.py

@@ -153,6 +153,36 @@ def setup_logging(level=DEFAULT_LOGGING_LEVEL, file_path=LOG_FILE_LOCATION):
 
 INVALID_JSON_MESSAGE = "Invalid json"
 
+PROJECT_SETTINGS_VALID_ATTRIBUTES = [
+    "Brightness",
+    "Fill",
+    "Contrast",
+    "ShowLabels",
+    "ShowComments",
+    "Image",
+    "Lines",
+    "AnnotatorFinish",
+    "PointSize",
+    "FontSize",
+    "WorkflowEnable",
+    "ClassChange",
+    "ShowEntropy",
+    "UploadImages",
+    "DeleteImages",
+    "Download",
+    "RunPredictions",
+    "RunSegmentations",
+    "ImageQuality",
+    "ImageAutoAssignCount",
+    "FrameMode",
+    "FrameRate",
+    "JumpBackward",
+    "JumpForward",
+    "UploadFileType",
+    "Tokenization",
+    "ImageAutoAssignEnable",
+]
+
 __alL__ = (
     FolderStatus,
     ProjectStatus,

src/superannotate/lib/core/usecases/projects.py

@@ -177,7 +177,7 @@ def __init__(
 
     def validate_settings(self):
         for setting in self._project.settings[:]:
-            if setting.attribute == "WorkflowType":
+            if setting.attribute not in constances.PROJECT_SETTINGS_VALID_ATTRIBUTES:
                 self._project.settings.remove(setting)
             if setting.attribute == "ImageQuality" and isinstance(setting.value, str):
                 setting.value = constances.ImageQuality.get_value(setting.value)
@@ -335,6 +335,39 @@ def __init__(
         self._project = project
         self._service_provider = service_provider
 
+    def validate_settings(self):
+        for setting in self._project.settings[:]:
+            if setting.attribute not in constances.PROJECT_SETTINGS_VALID_ATTRIBUTES:
+                self._project.settings.remove(setting)
+            if setting.attribute == "ImageQuality" and isinstance(setting.value, str):
+                setting.value = constances.ImageQuality.get_value(setting.value)
+            elif setting.attribute == "FrameRate":
+                if not self._project.type == constances.ProjectType.VIDEO.value:
+                    raise AppValidationException(
+                        "FrameRate is available only for Video projects"
+                    )
+                try:
+                    setting.value = float(setting.value)
+                    if (
+                        not (0.0001 < setting.value < 120)
+                        or decimal.Decimal(str(setting.value)).as_tuple().exponent < -3
+                    ):
+                        raise AppValidationException(
+                            "The FrameRate value range is between 0.001 - 120"
+                        )
+                    frame_mode = next(
+                        filter(
+                            lambda x: x.attribute == "FrameMode", self._project.settings
+                        ),
+                        None,
+                    )
+                    if not frame_mode:
+                        self._project.settings.append(
+                            SettingEntity(attribute="FrameMode", value=1)
+                        )
+                except ValueError:
+                    raise AppValidationException("The FrameRate value should be float")
+
     def validate_project_name(self):
         if self._project.name:
             if (
@@ -488,13 +521,17 @@ def execute(self):
 
             new_settings_to_update = []
             for new_setting in self._to_update:
-                new_settings_to_update.append(
-                    SettingEntity(
-                        id=attr_id_mapping[new_setting["attribute"]],
-                        attribute=new_setting["attribute"],
-                        value=new_setting["value"],
+                if (
+                    new_setting["attribute"]
+                    in constances.PROJECT_SETTINGS_VALID_ATTRIBUTES
+                ):
+                    new_settings_to_update.append(
+                        SettingEntity(
+                            id=attr_id_mapping[new_setting["attribute"]],
+                            attribute=new_setting["attribute"],
+                            value=new_setting["value"],
+                        )
                     )
-                )
 
             response = self._service_provider.projects.set_settings(
                 project=self._project,

tests/integration/projects/test_basic_project.py

@@ -176,7 +176,10 @@ def test_basic_project(self):
             for json_in_folder in self.folder_path.glob("*.json"):
                 found = False
                 for json_in_project in Path(temp_dir).glob("*.json"):
-                    if json_in_folder.name == json_in_project.name:
+                    if (
+                        json_in_folder.name.replace("___pixel", "")
+                        == json_in_project.name
+                    ):
                         found = True
                         break
                 assert found, json_in_folder