Merge pull request #605 from superannotateai/1935_serializers

changes in entities to backend response independent

Author: nareksa

requirements_extra.txt

@@ -1,4 +1,4 @@
-Sphinx==6.1.3
+Sphinx==6.2.1
 Jinja2==3.1.2
 tox==4.4.5
 sphinx_rtd_theme==1.2.0

src/superannotate/lib/app/interface/sdk_interface.py

@@ -730,10 +730,7 @@ def search_annotation_classes(
         response = self.controller.annotation_classes.list(condition)
         if response.errors:
             raise AppException(response.errors)
-        return [
-            i.dict(exclude={"attribute_groups": {"__all__": {"is_multiselect"}}})
-            for i in response.data
-        ]
+        return response.data
 
     def set_project_status(self, project: NotEmptyStr, status: PROJECT_STATUS):
         """Set project status

src/superannotate/lib/core/entities/__init__.py

@@ -19,7 +19,6 @@
 from lib.core.entities.project import UserEntity
 from lib.core.entities.project import WorkflowEntity
 from lib.core.entities.project_entities import BaseEntity
-from lib.core.entities.project_entities import ImageInfoEntity
 from lib.core.entities.project_entities import S3FileEntity
 
 __all__ = [
@@ -44,7 +43,6 @@
     "ConfigEntity",
     "WorkflowEntity",
     "FolderEntity",
-    "ImageInfoEntity",
     "S3FileEntity",
     "AnnotationClassEntity",
     "TeamEntity",

src/superannotate/lib/core/entities/classes.py

@@ -62,7 +62,7 @@ class Attribute(TimedBaseModel):
     name: Optional[StrictStr]
 
     class Config:
-        extra = Extra.allow
+        extra = Extra.ignore
 
     def __hash__(self):
         return hash(f"{self.id}{self.group_id}{self.name}")
@@ -73,12 +73,11 @@ class AttributeGroup(TimedBaseModel):
     group_type: Optional[GroupTypeEnum]
     class_id: Optional[StrictInt]
     name: Optional[StrictStr]
-    is_multiselect: Optional[bool]
     attributes: Optional[List[Attribute]]
     default_value: Any
 
     class Config:
-        extra = Extra.allow
+        extra = Extra.ignore
         use_enum_values = True
 
     def __hash__(self):
@@ -97,7 +96,7 @@ def __hash__(self):
         return hash(f"{self.id}{self.type}{self.name}")
 
     class Config:
-        extra = Extra.allow
+        extra = Extra.ignore
         json_encoders = {
             HexColor: lambda v: v.__root__,
             BaseTitledEnum: lambda v: v.value,

src/superannotate/lib/core/entities/folder.py

@@ -12,7 +12,7 @@ class FolderEntity(TimedBaseModel):
     status: Optional[FolderStatus]
     project_id: Optional[int]
     team_id: Optional[int]
-    is_root: Optional[bool] = (False,)
+    is_root: Optional[bool] = False
     folder_users: Optional[List[dict]]
     completedCount: Optional[int]
 

src/superannotate/lib/core/entities/project.py

@@ -33,12 +33,8 @@ def validate(cls, v: datetime):
 
 
 class TimedBaseModel(BaseModel):
-    createdAt: Optional[StringDate] = Field(
-        None, alias="createdAt", description="Date of creation"
-    )
-    updatedAt: Optional[StringDate] = Field(
-        None, alias="updatedAt", description="Update date"
-    )
+    createdAt: Optional[StringDate] = None
+    updatedAt: Optional[StringDate] = None
 
 
 class AttachmentEntity(BaseModel):
@@ -59,7 +55,10 @@ class WorkflowEntity(BaseModel):
     className: Optional[str]
     step: Optional[int]
     tool: Optional[int]
-    attribute: List = (tuple(),)
+    attribute: List = tuple()
+
+    class Config:
+        extra = Extra.ignore
 
     def __copy__(self):
         return WorkflowEntity(step=self.step, tool=self.tool, attribute=self.attribute)
@@ -91,8 +90,8 @@ class Config:
 class ProjectEntity(TimedBaseModel):
     id: Optional[int]
     team_id: Optional[int]
-    name: Optional[str]
-    type: Optional[ProjectType]
+    name: str
+    type: ProjectType
     description: Optional[str]
     instructions_link: Optional[str]
     creator_id: Optional[str]

src/superannotate/lib/core/entities/project_entities.py

@@ -24,24 +24,6 @@ def to_dict(self):
         raise NotImplementedError
 
 
-class ImageInfoEntity(BaseEntity):
-    def __init__(
-        self,
-        uuid=None,
-        width: float = None,
-        height: float = None,
-    ):
-        super().__init__(uuid),
-        self.width = width
-        self.height = height
-
-    def to_dict(self):
-        return {
-            "width": self.width,
-            "height": self.height,
-        }
-
-
 class S3FileEntity(BaseEntity):
     def __init__(self, uuid, data, metadata: dict = None):
         super().__init__(uuid)

src/superannotate/lib/core/usecases/classes.py

@@ -28,7 +28,11 @@ def __init__(
     def execute(self):
         response = self._service_provider.annotation_classes.list(self._condition)
         if response.ok:
-            self._response.data = response.data
+            classes = [
+                entity.dict(by_alias=True, exclude_unset=True)
+                for entity in response.data
+            ]
+            self._response.data = classes
         else:
             self._response.errors = response.error
         return self._response

tests/__init__.py

@@ -8,9 +8,13 @@
 DATA_SET_PATH = Path(__file__).parent / "data_set"
 sys.path.insert(0, str(LIB_PATH))
 
-__all__ = ["DATA_SET_PATH"]
 
-# from src.superannotate.lib.core import setup_logging
-#
-# logger = get_default_logger()
-# logger.setLevel("DEBUG")
+def compare_result(result: dict, expected: dict, ignore_keys: set = None):
+    for key in result:
+        if ignore_keys and key in ignore_keys:
+            continue
+        assert result[key] == expected[key]
+    return True
+
+
+__all__ = ["DATA_SET_PATH", "compare_result"]

tests/integration/classes/test_create_annotation_class.py

@@ -64,7 +64,7 @@ def test_multi_select_to_checklist(self):
             attribute_groups=[
                 {
                     "name": "test",
-                    "is_multiselect": 1,
+                    "group_type": "checklist",
                     "attributes": [{"name": "Car"}, {"name": "Track"}, {"name": "Bus"}],
                 }
             ],