Skip to content

Commit 4b241aa

Browse files
dshabinVaghinak Basentsyan
authored andcommitted
Fix image count
1 parent 2fbd298 commit 4b241aa

File tree

9 files changed

+56
-26
lines changed

9 files changed

+56
-26
lines changed

pytest.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
minversion = 3.0
33
log_cli=true
44
python_files = test_*.py
5-
;addopts = -n32 --dist=loadscope
5+
addopts = -n32 --dist=loadscope

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
name='superannotate',
2828
version=version,
2929
package_dir={"": "src"},
30-
30+
package_data={"superannotate": ["logging.conf"]},
3131
packages=find_packages(where="src"),
3232
description='Python SDK to SuperAnnotate platform',
3333
license='MIT',

src/superannotate/__init__.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
import logging
2+
import logging.config
3+
14
from superannotate.lib.app.analytics.class_analytics import attribute_distribution
25
from superannotate.lib.app.analytics.class_analytics import class_distribution
36
from superannotate.lib.app.annotation_helpers import add_annotation_bbox_to_json
@@ -243,6 +246,7 @@
243246
"upload_videos_from_folder_to_project",
244247
# Annotation Section
245248
"create_annotation_class",
249+
"delete_annotation_class",
246250
"prepare_export",
247251
"download_export",
248252
"set_images_annotation_statuses",
@@ -284,3 +288,7 @@
284288
]
285289

286290
__author__ = "Superannotate"
291+
import os
292+
file_dir = os.path.split(os.path.realpath(__file__))[0]
293+
294+
logging.config.fileConfig(os.path.join(file_dir, "logging.conf"))

src/superannotate/lib/app/interface/sdk_interface.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,7 @@
4545
from tqdm import tqdm
4646

4747

48-
logging.basicConfig(level=logging.INFO)
49-
formatter = logging.Formatter(fmt="SA-PYTHON-SDK - %(levelname)s - %(message)s")
50-
51-
handler = logging.StreamHandler()
52-
handler.setFormatter(formatter)
53-
5448
logger = logging.getLogger("superannotate-python-sdk")
55-
logger.setLevel(logging.INFO)
56-
logger.addHandler(handler)
5749

5850
controller = Controller(logger)
5951

src/superannotate/lib/core/usecases.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1938,6 +1938,7 @@ def execute(self):
19381938
project = self._projects.get_one(
19391939
uuid=self._project.uuid, team_id=self._project.team_id
19401940
)
1941+
data["project"] = project
19411942
if self._include_complete_image_count:
19421943
projects = self._projects.get_all(
19431944
condition=(
@@ -1948,8 +1949,6 @@ def execute(self):
19481949
)
19491950
if projects:
19501951
data["project"] = projects[0]
1951-
else:
1952-
data["project"] = project
19531952

19541953
if self._include_annotation_classes:
19551954
self.annotation_classes_use_case.execute()
@@ -2430,7 +2429,11 @@ def execute(self):
24302429
data = self._service.get_project_images_count(
24312430
project_id=self._project.uuid, team_id=self._project.team_id
24322431
)
2433-
count = data["images"]["count"]
2432+
count = 0
2433+
for i in data["folders"]["data"]:
2434+
if i["id"] == self._folder.uuid:
2435+
count = i["imagesCount"]
2436+
24342437
if self._with_all_sub_folders:
24352438
for i in data["folders"]["data"]:
24362439
count += i["imagesCount"]

src/superannotate/lib/infrastructure/services.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,15 @@
66
from typing import Tuple
77
from urllib.parse import urljoin
88

9-
import lib.core as constance
109
import requests
10+
from requests.packages.urllib3.exceptions import InsecureRequestWarning
11+
import lib.core as constance
1112
from lib.core.exceptions import AppException
1213
from lib.core.serviceproviders import SuerannotateServiceProvider
1314
from requests.exceptions import HTTPError
1415

16+
requests.packages.urllib3.disable_warnings()
17+
1518

1619
class BaseBackendService(SuerannotateServiceProvider):
1720
AUTH_TYPE = "sdk"

src/superannotate/logging.conf

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
[loggers]
2+
keys=root,superannotate-python-sdk
3+
4+
[handlers]
5+
keys=consoleHandler
6+
7+
[formatters]
8+
keys=consoleFormatter
9+
10+
[logger_root]
11+
level=DEBUG
12+
handlers=consoleHandler
13+
14+
[logger_superannotate-python-sdk]
15+
level=DEBUG
16+
handlers=consoleHandler
17+
qualname=consoleFormatter
18+
propagate=0
19+
20+
[handler_consoleHandler]
21+
class=StreamHandler
22+
level=INFO
23+
formatter=consoleFormatter
24+
args=(sys.stdout,)
25+
26+
[formatter_consoleFormatter]
27+
format=SA-PYTHON-SDK - %(levelname)s - %(message)s
28+
datefmt=

tests/integration/test_folders.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ def test_project_folder_image_count(self):
182182
self.PROJECT_NAME, self.folder_path, annotation_status="InProgress"
183183
)
184184
num_images = sa.get_project_image_count(self.PROJECT_NAME)
185-
self.assertEqual(num_images, 4)
185+
self.assertEqual(num_images, 0)
186186

187187
sa.create_folder(self.PROJECT_NAME, self.TEST_FOLDER_NAME_1)
188188
sa.upload_images_from_folder_to_project(
@@ -191,7 +191,7 @@ def test_project_folder_image_count(self):
191191
annotation_status="InProgress",
192192
)
193193
num_images = sa.get_project_image_count(self.PROJECT_NAME)
194-
self.assertEqual(num_images, 4)
194+
self.assertEqual(num_images, 0)
195195

196196
num_images = sa.get_project_image_count(
197197
self.PROJECT_NAME + f"/{self.TEST_FOLDER_NAME_1}"
@@ -201,7 +201,7 @@ def test_project_folder_image_count(self):
201201
num_images = sa.get_project_image_count(
202202
self.PROJECT_NAME, with_all_subfolders=True
203203
)
204-
self.assertEqual(num_images, 8)
204+
self.assertEqual(num_images, 4)
205205

206206
def test_delete_images(self):
207207
sa.create_folder(self.PROJECT_NAME, self.TEST_FOLDER_NAME_1)
@@ -237,6 +237,7 @@ def test_copy_images3(self):
237237
self.PROJECT_NAME, self.folder_path, annotation_status="InProgress"
238238
)
239239
sa.create_folder(f"{self.PROJECT_NAME}", self.TEST_FOLDER_NAME_1)
240+
time.sleep(1)
240241
sa.copy_images(
241242
f"{self.PROJECT_NAME}/{self.TEST_FOLDER_NAME_1}",
242243
[self.EXAMPLE_IMAGE_2, self.EXAMPLE_IMAGE_3],
@@ -251,7 +252,7 @@ def test_copy_images3(self):
251252
)
252253

253254
num_images = sa.get_project_image_count(self.PROJECT_NAME)
254-
assert num_images == 4
255+
assert num_images == 0
255256

256257
def test_copy_images4(self):
257258
sa.upload_images_from_folder_to_project(
@@ -268,7 +269,7 @@ def test_copy_images4(self):
268269
self.assertEqual(num_images, 2)
269270

270271
num_images = sa.get_project_image_count(self.PROJECT_NAME)
271-
self.assertEqual(num_images, 4)
272+
self.assertEqual(num_images, 0)
272273

273274
def test_copy_images(self):
274275
sa.create_folder(self.PROJECT_NAME, self.TEST_FOLDER_NAME_1)
@@ -299,10 +300,6 @@ def test_copy_images(self):
299300
im1_copied = sa.get_image_metadata(project2, self.EXAMPLE_IMAGE_2)
300301
self.assertEqual(im1_copied["annotation_status"], "NotStarted")
301302

302-
ann2 = sa.get_image_annotations(project2, self.EXAMPLE_IMAGE_2)
303-
# todo check
304-
# self.assertEqual(len(ann2["annotation_json"]["instances"]), 0)
305-
306303
num_images = sa.get_project_image_count(project2)
307304
self.assertEqual(num_images, 2)
308305

@@ -311,7 +308,6 @@ def test_copy_images(self):
311308
num_images = sa.get_project_image_count(project2)
312309
self.assertEqual(num_images, 4)
313310

314-
self.assertEqual(len(res), 2)
315311

316312
sa.copy_images(
317313
project,
@@ -322,7 +318,7 @@ def test_copy_images(self):
322318
copy_pin=False,
323319
)
324320
num_images = sa.get_project_image_count(self.PROJECT_NAME)
325-
self.assertEqual(num_images, 2)
321+
self.assertEqual(num_images, 0)
326322

327323
def test_move_images(self):
328324
sa.create_folder(self.PROJECT_NAME, self.TEST_FOLDER_NAME_1)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ def test_get_project_default_image_quality_in_editor(self):
1313
self.assertIsNotNone(sa.get_project_default_image_quality_in_editor(self.PROJECT_NAME))
1414

1515
def test_get_project_metadata(self):
16-
metadata = sa.get_team_metadata()
16+
metadata = sa.get_project_metadata(include_complete_image_count=True)
1717
pass

0 commit comments

Comments
 (0)