Skip to content

Commit 21f448d

Browse files
dshabinVaghinak Basentsyan
authored andcommitted
Fix log message
1 parent 248eb3d commit 21f448d

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

src/superannotate/lib/app/input_converters/converters/coco_converters/sa_vector_to_coco.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def sa_vector_to_coco_object_detection(
2222
for instance in instances:
2323
if instance["type"] != "bbox":
2424
logger.warning(
25-
"Skipping '%s' type convertion during object_detection task",
25+
"Skipping '%s' type conversion during object_detection task",
2626
instance["type"],
2727
)
2828
continue
@@ -60,7 +60,7 @@ def sa_vector_to_coco_instance_segmentation(
6060
for instance in instances:
6161
if instance["type"] != "polygon":
6262
logger.warning(
63-
"Skipping '%s' type convertion during object_detection task",
63+
"Skipping '%s' type conversion during instance_segmentation task",
6464
instance["type"],
6565
)
6666
continue

src/superannotate/lib/core/types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ class PixelAnnotationPart(BaseModel):
113113

114114
class PixelAnnotationInstance(BaseModel):
115115
classId: int
116-
groupId: int
116+
groupId: Optional[int]
117117
parts: List[PixelAnnotationPart]
118118
attributes: List[Attribute]
119119

src/superannotate/lib/core/usecases.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3760,6 +3760,7 @@ def upload_to_s3(
37603760
self.fill_classes_data(annotation_json)
37613761

37623762
if not self._is_valid_json(annotation_json):
3763+
logger.warning(f"Invalid json {image_id_name_map[image_id].path}")
37633764
return image_id_name_map[image_id], False
37643765
bucket.put_object(
37653766
Key=image_info["annotation_json_path"], Body=json.dumps(annotation_json),

tests/integration/test_depricated_functions_video.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
import os
22
from os.path import dirname
3+
from unittest import TestCase
4+
35
import src.superannotate as sa
46
from src.superannotate import AppException
5-
from tests.integration.base import BaseTestCase
67
from src.superannotate.lib.core import LIMITED_FUNCTIONS
78
from src.superannotate.lib.core import ProjectType
89
from src.superannotate.lib.core import DEPRICATED_DOCUMENT_VIDEO_MESSAGE
910

1011

11-
class TestDeprecatedFunctionsVideo(BaseTestCase):
12+
class TestDeprecatedFunctionsVideo(TestCase):
1213
PROJECT_NAME = "vid proj 11"
1314
PROJECT_DESCRIPTION = "desc"
1415
PROJECT_TYPE = "Video"

tests/integration/test_interface.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ def test_image_upload_with_set_name_on_platform(self):
166166
sa.upload_image_to_project(self.PROJECT_NAME, self.IMAGE_PATH_IN_S3 , self.NEW_IMAGE_NAME,from_s3_bucket=self.TEST_S3_BUCKET_NAME)
167167
self.assertIn(sa.search_images(self.PROJECT_NAME)[0],self.NEW_IMAGE_NAME)
168168

169-
170169
def test_download_fuse_without_classes(self):
171170
sa.upload_image_to_project(self.PROJECT_NAME, f"{self.folder_path}/{self.EXAMPLE_IMAGE_1}")
172171
sa.upload_image_annotations(

0 commit comments

Comments
 (0)