chore: cleanup quality

Author: fhussonnois

spotbugs/spotbugs-security-exclude.xml renamed to .spotbugs/spotbugs-security-exclude.xml

@@ -13,21 +13,21 @@
 [![Coverage](https://sonarcloud.io/api/project_badges/measure?project=streamthoughts_kafka-connect-file-pulse&metric=coverage)](https://sonarcloud.io/summary/new_code?id=streamthoughts_kafka-connect-file-pulse)
 
 <p align="center">
-  <img width="400" height="400" src="https://github.com/streamthoughts/kafka-connect-file-pulse/raw/master/assets/logo.png">
+<img width="400" height="400" src="https://github.com/streamthoughts/kafka-connect-file-pulse/raw/master/assets/logo.png">
 </p>
 
-**Connect FilePulse** is a multipurpose, scalable and reliable, 
+**Connect FilePulse** is a multipurpose, scalable and reliable,
 [Kafka Connector](http://kafka.apache.org/documentation.html#connect) that makes it easy to parse, transform and stream any file, in any format, into Apache Kafka™.
-It provides capabilities for reading files from: **local-filesystem**, **Amazon S3**, **Azure Storage** and **Google Cloud Storage**. 
+It provides capabilities for reading files from: **local-filesystem**, **Amazon S3**, **Azure Storage** and **Google Cloud Storage**.
 
 ## Motivation
 
 In organizations, data is frequently exported, shared and integrated from legacy systems through the use of
 files in a wide variety of formats (e.g. CSV, XML, JSON, Avro, etc.). Dealing with all of these formats can
 quickly become a real challenge for enterprise that usually end up with a complex and hard
 to maintain data integration mess.
-	
-	
+
+
 A modern approach consists in building a scalable data streaming platform as a central nervous
 system to decouple applications from each other. **Apache Kafka™** is one of the most widely
 used technologies to build such a system. The Apache Kafka project packs with Kafka Connect a distributed,
@@ -54,7 +54,7 @@ Connect FilePulse provides a set of built-in features for streaming files from m
 
 ## 🙏 Show your support
 
-You think this project can help you or your team to ingest data into Kafka ? 
+You think this project can help you or your team to ingest data into Kafka ?
 Please 🌟 this repository to support us!
 
 ## 🏁 How to get started ?
@@ -87,4 +87,4 @@ Licensed to the Apache Software Foundation (ASF) under one or more contributor l
 
 [http://www.apache.org/licenses/LICENSE-2.0](http://www.apache.org/licenses/LICENSE-2.0)
 
-Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License
+Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License

spotbugs/spotbugs-security-include.xml renamed to .spotbugs/spotbugs-security-include.xml

@@ -17,58 +17,44 @@
   ~ See the License for the specific language governing permissions and
   ~ limitations under the License.
   -->
-
 <!DOCTYPE module PUBLIC
-        "-//Checkstyle//DTD Checkstyle Configuration 1.2//EN"
-        "https://checkstyle.org/dtds/configuration_1_2.dtd">
+        "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+        "https://checkstyle.org/dtds/configuration_1_3.dtd">
+
 <module name="Checker">
-<!--
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
- -->
     <property name="localeLanguage" value="en"/>
+    <property name="charset" value="UTF-8"/>
 
+    <property name="fileExtensions" value="java, properties, xml"/>
+    <!-- https://checkstyle.org/config_filters.html#SuppressionFilter -->
+    <module name="SuppressionFilter">
+        <property name="file" value="${basedir}/checkstyle/suppressions.xml"/>
+    </module>
     <module name="Header">
-        <property name="headerFile" value="${basedir}/checkstyle/apache-header" />
+        <property name="headerFile" value="${basedir}/license-header" />
         <property name="ignoreLines" value="1, 2"/>
     </module>
 
+    <module name="LineLength">
+        <property name="fileExtensions" value="java"/>
+        <property name="max" value="120"/>
+        <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
+    </module>
+
     <module name="TreeWalker">
-        <!-- Imports -->
         <module name="UnusedImports">
             <property name="processJavadoc" value="true" />
         </module>
         <module name="RedundantImport"/>
         <module name="IllegalImport" />
         <module name="AvoidStarImport"/>
-
-        <!-- Code General Quality / Style -->
         <module name="OneStatementPerLine"/>
-        <module name="UnnecessaryParentheses" />
+        <module name="MultipleVariableDeclarations"/>
         <module name="MethodLength"/>
-        <module name="LineLength">
-            <property name="max" value="120"/>
-        </module>
         <module name="EqualsHashCode"/>
         <module name="ParameterNumber"/>
         <module name="SimplifyBooleanExpression"/>
         <module name="SimplifyBooleanReturn"/>
-
-        <!-- Code Complexity -->
         <module name="CyclomaticComplexity">
             <!-- default is 10 -->
             <property name="max" value="15"/>
@@ -89,9 +75,26 @@
             <!-- default is 3 -->
             <property name="max" value="4"/>
         </module>
-    </module>
-
-    <module name="SuppressionFilter">
-        <property name="file" value="${basedir}/checkstyle/suppressions.xml"/>
+        <module name="MemberName">
+            <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
+            <message key="name.invalidPattern"
+                     value="Member name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="LocalVariableName">
+            <property name="format" value="^[a-z]([a-z0-9][a-zA-Z0-9]*)?$"/>
+            <message key="name.invalidPattern"
+                     value="Local variable name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="PackageName">
+            <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]*)*$"/>
+            <message key="name.invalidPattern"
+                     value="Package name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="InterfaceTypeParameterName">
+            <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
+            <message key="name.invalidPattern"
+                     value="Interface type name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="NoFinalizer"/>
     </module>
 </module>

README.md

@@ -50,6 +50,7 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <checkstyle.config.location>${project.parent.basedir}</checkstyle.config.location>
+        <license.header.file>${project.parent.basedir}/license-header</license.header.file>
     </properties>
 
     <build>

checkstyle/checkstyle.xml

@@ -19,7 +19,6 @@
 package io.streamthoughts.kafka.connect.filepulse.clean;
 
 import io.streamthoughts.kafka.connect.filepulse.source.FileObject;
-
 import java.util.List;
 
 /**

connect-file-pulse-api/pom.xml

@@ -20,7 +20,6 @@
 
 import io.streamthoughts.kafka.connect.filepulse.fs.Storage;
 import io.streamthoughts.kafka.connect.filepulse.source.FileObject;
-
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;

connect-file-pulse-api/src/main/java/io/streamthoughts/kafka/connect/filepulse/clean/BatchFileCleanupPolicy.java

@@ -20,7 +20,6 @@
 
 import io.streamthoughts.kafka.connect.filepulse.source.FileObject;
 import io.streamthoughts.kafka.connect.filepulse.source.FileObjectStatus;
-
 import java.util.Map;
 
 /**

connect-file-pulse-api/src/main/java/io/streamthoughts/kafka/connect/filepulse/clean/DelegateBatchFileCleanupPolicy.java

@@ -20,7 +20,6 @@
 
 import io.streamthoughts.kafka.connect.filepulse.internal.KeyValuePair;
 import io.streamthoughts.kafka.connect.filepulse.source.FileObject;
-
 import java.util.Collection;
 import java.util.LinkedList;
 import java.util.Objects;

connect-file-pulse-api/src/main/java/io/streamthoughts/kafka/connect/filepulse/clean/FileCleanupPolicy.java

@@ -19,9 +19,8 @@
 package io.streamthoughts.kafka.connect.filepulse.clean;
 
 import io.streamthoughts.kafka.connect.filepulse.fs.StorageAware;
-import org.apache.kafka.common.Configurable;
-
 import java.util.Map;
+import org.apache.kafka.common.Configurable;
 
 /**
  * Top level interface for cleanup policies.