Skip to content

Commit 28c6149

Browse files
committed
refactor(docker): improve docker image build
1 parent e8d1bd5 commit 28c6149

File tree

2 files changed

+41
-2
lines changed

2 files changed

+41
-2
lines changed

Dockerfile

Lines changed: 33 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,39 @@
1+
2+
# Copyright 2019-2020 StreamThoughts.
3+
#
4+
# Licensed to the Apache Software Foundation (ASF) under one or more
5+
# contributor license agreements. See the NOTICE file distributed with
6+
# this work for additional information regarding copyright ownership.
7+
# The ASF licenses this file to You under the Apache License, Version 2.0
8+
# (the "License"); you may not use this file except in compliance with
9+
# the License. You may obtain a copy of the License at
10+
#
11+
# http://www.apache.org/licenses/LICENSE-2.0
12+
#
13+
# Unless required by applicable law or agreed to in writing, software
14+
# distributed under the License is distributed on an "AS IS" BASIS,
15+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16+
# See the License for the specific language governing permissions and
17+
# limitations under the License.
18+
#
19+
# Kafka Connect File Pulse
120
FROM confluentinc/cp-kafka-connect-base:5.2.1
221

3-
COPY connect-file-pulse-plugin/target/components/packages/streamthoughts-kafka-connect-file-pulse-1.3.0-SNAPSHOT.zip /tmp/kafka-connect-file-pulse.zip
22+
ARG connectFilePulseVersion
23+
ARG connectFilePulseBranch
24+
ARG connectFilePulseCommit
25+
26+
ENV FILE_PULSE_VERSION="${connectFilePulseVersion}" \
27+
FILE_PULSE_COMMIT="${connectFilePulseCommit}" \
28+
FILE_PULSE_BRANCH="${connectFilePulseBranch}"
29+
30+
COPY connect-file-pulse-plugin/target/components/packages/streamthoughts-kafka-connect-file-pulse-${FILE_PULSE_VERSION}.zip /tmp/kafka-connect-file-pulse.zip
431
RUN confluent-hub install --no-prompt /tmp/kafka-connect-file-pulse.zip && \
532
rm -rf /tmp/kafka-connect-file-pulse.zip
633

734
COPY include/docker/connect-log4j.properties.template /etc/confluent/docker/log4j.properties.template
35+
36+
LABEL io.streamthoughts.docker.name="kafka-connect-file-pulse" \
37+
io.streamthoughts.docker.version=$FILE_PULSE_VERSION \
38+
io.streamthoughts.docker.branch=$FILE_PULSE_BRANCH \
39+
io.streamthoughts.docker.commit=$FILE_PULSE_COMMIT

Makefile

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# Makefile used to build docker images for Connect File Pulse
22

33
CONNECT_VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:3.1.0:evaluate -Dexpression=project.version -q -DforceStdout)
4+
GIT_COMMIT := $(shell git rev-parse --short HEAD)
5+
GIT_BRANCH := $(shell git rev-parse --abbrev-ref HEAD)
46

57
REPOSITORY = streamthoughts
68
IMAGE = kafka-connect-file-pulse
@@ -26,9 +28,14 @@ clean-build:
2628
build-images:
2729
echo "Building image \n========================================== ";
2830
echo "CONNECT_VERSION="$(CONNECT_VERSION)
31+
echo "GIT_COMMIT="$(GIT_COMMIT)
32+
echo "GIT_BRANCH="$(GIT_BRANCH)
2933
echo "==========================================\n "
30-
mvn clean package && \
34+
mvn clean package -q && \
3135
docker build \
36+
--build-arg connectFilePulseVersion=${CONNECT_VERSION} \
37+
--build-arg connectFilePulseCommit=${GIT_COMMIT} \
38+
--build-arg connectFilePulseBranch=${GIT_BRANCH} \
3239
-t ${REPOSITORY}/${IMAGE}:latest . || exit 1 ;
3340
docker tag ${REPOSITORY}/${IMAGE}:latest ${REPOSITORY}/${IMAGE}:${CONNECT_VERSION} || exit 1 ;
3441

0 commit comments

Comments
 (0)