From 334bd8c61e8b5e8aa9d1c6ceab7a5ebd68bdf43b Mon Sep 17 00:00:00 2001 From: Dev Kumar Date: Sun, 5 Jul 2026 20:54:59 -0500 Subject: [PATCH 1/2] fix: remove all-primitive-deps warning from useDeepCompareEffect (closes #755) --- src/useDeepCompareEffect.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/useDeepCompareEffect.ts b/src/useDeepCompareEffect.ts index 14c08c4ff0..f08c92228a 100644 --- a/src/useDeepCompareEffect.ts +++ b/src/useDeepCompareEffect.ts @@ -2,8 +2,6 @@ import { DependencyList, EffectCallback } from 'react'; import useCustomCompareEffect from './useCustomCompareEffect'; import isDeepEqual from './misc/isDeepEqual'; -const isPrimitive = (val: any) => val !== Object(val); - const useDeepCompareEffect = (effect: EffectCallback, deps: DependencyList) => { if (process.env.NODE_ENV !== 'production') { if (!(deps instanceof Array) || !deps.length) { @@ -11,12 +9,6 @@ const useDeepCompareEffect = (effect: EffectCallback, deps: DependencyList) => { '`useDeepCompareEffect` should not be used with no dependencies. Use React.useEffect instead.' ); } - - if (deps.every(isPrimitive)) { - console.warn( - '`useDeepCompareEffect` should not be used with dependencies that are all primitive values. Use React.useEffect instead.' - ); - } } useCustomCompareEffect(effect, deps, isDeepEqual); From 83ff425ebc01acd9251eb235cd7a81b3cd2a7bfd Mon Sep 17 00:00:00 2001 From: Dev Kumar Date: Sun, 5 Jul 2026 20:55:06 -0500 Subject: [PATCH 2/2] fix: remove all-primitive-deps warning from useShallowCompareEffect (closes #755) --- src/useShallowCompareEffect.ts | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/useShallowCompareEffect.ts b/src/useShallowCompareEffect.ts index 2c6e4808c9..262f49fb30 100644 --- a/src/useShallowCompareEffect.ts +++ b/src/useShallowCompareEffect.ts @@ -2,7 +2,6 @@ import { DependencyList, EffectCallback } from 'react'; import { equal as isShallowEqual } from 'fast-shallow-equal'; import useCustomCompareEffect from './useCustomCompareEffect'; -const isPrimitive = (val: any) => val !== Object(val); const shallowEqualDepsList = (prevDeps: DependencyList, nextDeps: DependencyList) => prevDeps.every((dep, index) => isShallowEqual(dep, nextDeps[index])); @@ -13,12 +12,6 @@ const useShallowCompareEffect = (effect: EffectCallback, deps: DependencyList) = '`useShallowCompareEffect` should not be used with no dependencies. Use React.useEffect instead.' ); } - - if (deps.every(isPrimitive)) { - console.warn( - '`useShallowCompareEffect` should not be used with dependencies that are all primitive values. Use React.useEffect instead.' - ); - } } useCustomCompareEffect(effect, deps, shallowEqualDepsList);